Add support for readOnlyRootFilesystem (fixes #1402) #1403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burmanm
approved these changes
Sep 10, 2024
|
I've added some tests, but it seems like enabling this is creating issues with Stargate (don't ask me why...) |
|
Unless it's the 4.1.5 upgrade that causes this. |
|
Silly me, Stargate v1 doesn't work with 4.1... |
adejanovski
force-pushed
the
k8op-251
branch
from
9170423
to
001b895
Compare
|
adejanovski
reviewed
Sep 12, 2024
| @@ -946,7 +946,7 @@ func checkDatacenterReadOnlyRootFS(t *testing.T, ctx context.Context, key framew | |||
| dc := &cassdcapi.CassandraDatacenter{} | |||
| err := f.Get(ctx, key, dc) | |||
| require.NoError(t, err) | |||
| require.Equal(t, *dc.Spec.ReadOnlyRootFilesystem, *kc.Spec.Cassandra.ReadOnlyRootFilesystem, "expected datacenter %s to have readOnlyRootFilesystem like it is in the kc", key.Name) | |||
| require.Equal(t, ptr.Deref(dc.Spec.ReadOnlyRootFilesystem, false), ptr.Deref(kc.Spec.Cassandra.ReadOnlyRootFilesystem, false), "expected datacenter %s to have readOnlyRootFilesystem like it is in the kc", key.Name) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Which issue(s) this PR fixes:
Fixes #1402
Checklist