Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support setting priority class of operator in Helm chart #956

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

DebakelOrakel
Copy link
Contributor

@DebakelOrakel DebakelOrakel commented Apr 16, 2024

Summary

Support setting priorityClassName of operator deployment in Helm chart.

Checklist

For Code changes

  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog
  • PR contains the label area:operator
  • Link this PR to related issues
  • I have not made any changes in the charts/ directory.

For Helm Chart changes

  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog
  • PR contains the label area:chart
  • PR contains the chart label, e.g. chart:k8up
  • Variables are documented in the values.yaml using the format required by Helm-Docs.
  • Chart Version bumped if immediate release after merging is planned
  • I have run make chart-docs
  • Link this PR to related code release or other issues.

@DebakelOrakel DebakelOrakel requested a review from a team as a code owner April 16, 2024 07:47
@DebakelOrakel DebakelOrakel requested review from tobru and Kidswiss and removed request for a team April 16, 2024 07:47
@TheBigLee
Copy link
Contributor

@DebakelOrakel Please sign your commit for the DCO check to pass.
Also don't forget to run make chart-docs

@DebakelOrakel DebakelOrakel force-pushed the feat/support-priorityclass branch from d3ac1b2 to 1f1c13b Compare May 28, 2024 11:47
Signed-off-by: Stephan Feurer <stephan.feurer@vshn.net>
@DebakelOrakel DebakelOrakel force-pushed the feat/support-priorityclass branch from 1f1c13b to 5732367 Compare May 28, 2024 11:48
@DebakelOrakel
Copy link
Contributor Author

@DebakelOrakel Please sign your commit for the DCO check to pass. Also don't forget to run make chart-docs

Done.

@Kidswiss
Copy link
Contributor

@DebakelOrakel thanks for the contribution!

@Kidswiss Kidswiss merged commit 2db912f into k8up-io:master Jul 23, 2024
7 checks passed
@DebakelOrakel DebakelOrakel deleted the feat/support-priorityclass branch August 2, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants