Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AWS provider version constraints to to be ">= 4.0" #2

Merged
merged 1 commit into from
Jul 26, 2023

Conversation

anasgrt
Copy link
Contributor

@anasgrt anasgrt commented Jul 26, 2023

What

Update the AWS Provider version constraints to be ">= 4.0"

Why

This module is used in Viaviela production environment and we are doing the update for the providers in terraform code for them and it shows some contradictions in terms of versions constraints ... so this update of this version constraints is required to avoid these contradiction.

Code Review

Please consider the following checklist when reviewing this Pull Request.
More background and details here.

  • Does the code actually solve the problem it was meant to solve?
  • Is the code covered by unit tests? Integration tests?
  • Does anything here need documentation? (Focus on why, not what.)
  • Does any of this code deal with privacy sensitive information or affects security? Ask an additional reviewer.
  • Is the code easy to understand and change in the future?
  • Is the same code or concept duplicated? Find a balance between DRYness and readability.
  • Does the code reasonably adhere to the Kabisa coding standards?
  • Be kind.

@anasgrt anasgrt changed the title update AWS provider version constraints to to be ">= 4.0" Fix AWS provider version constraints to to be ">= 4.0" Jul 26, 2023
@tmeijn
Copy link

tmeijn commented Jul 26, 2023

Hey @anasnedtech This looks good to me! To be sure, did you try terraform init with your v5 provider and in produced no errors?

@anasgrt
Copy link
Contributor Author

anasgrt commented Jul 26, 2023

Hey @anasnedtech This looks good to me! To be sure, did you try terraform init with your v5 provider and in produced no errors?

@tmeijn yes I did the test already...it works.

@anasgrt anasgrt merged commit 2bc9925 into main Jul 26, 2023
1 of 2 checks passed
@anasgrt anasgrt deleted the chore/upgrade_aws_required_providers_constraints branch July 26, 2023 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants