feat(hd-wallet): add package #1151

javadkh2 · 2023-10-31T14:09:43Z

This is the first PR related to hd-wallet
check readme and ADRs for more information

changeset-bot · 2023-10-31T14:09:47Z

🦋 Changeset detected

Latest commit: e041095

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel · 2023-10-31T14:09:51Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Ignored Deployments

Name	Status	Preview	Updated (UTC)
alpha-docs	⬜️ Ignored (Inspect)	Visit Preview	Nov 17, 2023 0:49am
docs-storybook	⬜️ Ignored (Inspect)	Visit Preview	Nov 17, 2023 0:49am
react-ui	⬜️ Ignored (Inspect)	Visit Preview	Nov 17, 2023 0:49am
tools	⬜️ Ignored (Inspect)	Visit Preview	Nov 17, 2023 0:49am

EnoF · 2023-11-02T15:58:06Z

packages/libs/hd-wallet/docs/decisions/0001-use-bip44.md

@@ -0,0 +1,53 @@
+# Use BIP44


Maybe somewhere in this decision record, you could also mention something about not supporting extended-public-keys

EnoF · 2023-11-06T10:50:25Z

packages/libs/hd-wallet/src/chainweaver/vendor/kadena-crypto.js

@@ -8360,8 +8362,8 @@ if (debugUtil && debugUtil.debuglog) {
 }
 /*</replacement>*/

-var BufferList = require('./internal/streams/BufferList.js');
-var destroyImpl = require('./internal/streams/destroy.js');
+var BufferList = require('./internal/streams/BufferList');


not sure if it matters, but potentially the removal of .js makes this extraction esm incompatible?

this bundle is created with browserify, I have copied it from the old lib.
it only work if I remove .js actually I didnt add them manually my VSCode did it when I move the file to the different path.
I will check esm compatibility

alber70g · 2023-11-08T12:15:55Z

.gitignore

+packages/tools/lint-package/src/helpers.js
+packages/tools/lint-package/src/index.js
+packages/tools/lint-package/src/logger.js
+packages/tools/lint-package/src/rules/api-extractor/types.js
+packages/tools/lint-package/src/rules/eslint/config.js
+packages/tools/lint-package/src/rules/package-json/scripts.js
+packages/tools/lint-package/src/rules/typescript/extends.js


Would it be better to make a separate PR for this?

Is this happening when running tsc in that package? It should, based on tsconfig, create a lib for files like this.

Do we maybe need a more generic one? Something like

packages/*/*/src/**/*.js

I don't know how they came up here

alber70g · 2023-11-08T12:16:17Z

packages/libs/hd-wallet/.gitignore

Do we need this file?

alber70g · 2023-11-08T12:17:23Z

packages/libs/hd-wallet/package.json

+    "lib"
+  ],
+  "scripts": {
+    "build": "tsc && cpy ./src/chainweaver/vendor/**/* ./lib/chainweaver/vendor/",


Can we add api-extractor to this package?

alber70g · 2023-11-08T12:22:05Z

packages/libs/hd-wallet/package.json

+  "name": "@kadena/hd-wallet",
+  "version": "0.0.1",
+  "private": true,
+  "description": "HD Wallet; key derivation",


Suggested change

"description": "HD Wallet; key derivation",

"description": "A common approach to work with mnemonic keys and key derivation for Kadena based on BIP39 BIP44",

alber70g · 2023-11-08T12:24:58Z

packages/libs/hd-wallet/src/index.ts

Is this generic for the other non-legacy/chainweaver implementation as well?

alber70g · 2023-11-08T12:25:50Z

packages/libs/hd-wallet/tsconfig.json

+  "extends": "./node_modules/@kadena-dev/shared-config/tsconfig-base.json",
+  "compilerOptions": {
+    "allowJs": false,
+    "lib": ["es2019", "DOM"]


Is it possible to not rely on DOM? Do you think that using DOM here will make this package potentially not work in non-DOM, nodejs, environment?

alber70g · 2023-11-08T13:13:00Z

packages/libs/hd-wallet/src/chainweaver/vendor/kadena-crypto.d.ts

+export declare const kadenaSign: (
+  password: string,
+  message: string,
+  privateKey: string,
+) => Uint8Array;


Can we change this to use the rootKey and
do we want to be signing multiple hashes at once to improve performance?

Suggested change

export declare const kadenaSign: (

password: string,

message: string,

privateKey: string,

) => Uint8Array;

export declare const kadenaSign: (

password: string,

rootKey: string | Uint8Array,

index: number,

...message: string[]

) => Uint8Array;

alber70g · 2023-11-08T13:15:40Z

packages/libs/hd-wallet/src/chainweaver/vendor/kadena-crypto.d.ts

+
+export declare const kadenaGenMnemonic: () => string;
+
+export declare const kadenaGetPublic: (secretKey: Uint8Array) => Uint8Array;


This function should probably accept the rootKey: string | Uint8Array, password: string, ...index: number[]

feat(hd-wallet): add package

3ff55db

docs(hd-wallet): fix link

2cddfea

javadkh2 requested review from alber70g, EnoF and Takadenoshi November 1, 2023 12:37

javadkh2 added 7 commits November 2, 2023 10:48

feat/chainweaver-bundle

030a30a

fix: dependency issue

fef63b4

chore: cean up

00b91c4

fix: types

9c943df

test: some unit test

90fec0f

chore: move chainweaver to /chainweaver

7e484e6

chore: add contibutors

b77929b

EnoF reviewed Nov 2, 2023

View reviewed changes

EnoF approved these changes Nov 2, 2023

View reviewed changes

nillo and others added 5 commits November 3, 2023 10:02

added cont

ea723e0

fix: kadena-crypto

2583896

docs(hd-wallet): update bip44 ADR

bb5c7f4

docs(hd-wallet): update bip44 ard

4f0f158

docs(hd-wallet): update bip44 ard

7b02cd8

EnoF reviewed Nov 6, 2023

View reviewed changes

EnoF approved these changes Nov 6, 2023

View reviewed changes

javadkh2 added 2 commits November 6, 2023 13:09

refactot: kadenaGenKeypair

ab0d912

refactot: kadenaGenKeypair

e09bd42

javadkh2 marked this pull request as ready for review November 7, 2023 12:17

alber70g reviewed Nov 8, 2023

View reviewed changes

packages/libs/hd-wallet/.gitignore Outdated

Copy link

Member

alber70g Nov 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this file?

alber70g reviewed Nov 8, 2023

View reviewed changes

packages/libs/hd-wallet/src/index.ts Outdated

Copy link

Member

alber70g Nov 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this generic for the other non-legacy/chainweaver implementation as well?

alber70g reviewed Nov 8, 2023

View reviewed changes

javadkh2 added 6 commits November 9, 2023 10:56

feat: chainweaver compatibility

175098c

refactor: hd-wallet rename some functions

629d0b4

chore: cleabup

a449c90

fix: imports

ffea630

chore: lint + changeset

b0fd9e7

docs: make bip44 proposal

e041095

javadkh2 merged commit 03b249a into main Nov 17, 2023
10 checks passed

javadkh2 deleted the feat/hd-wallet branch November 17, 2023 12:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(hd-wallet): add package #1151

feat(hd-wallet): add package #1151

javadkh2 commented Oct 31, 2023

changeset-bot bot commented Oct 31, 2023 •

edited

Loading

vercel bot commented Oct 31, 2023 •

edited

Loading

EnoF Nov 2, 2023

EnoF Nov 6, 2023

javadkh2 Nov 6, 2023

alber70g Nov 8, 2023

javadkh2 Nov 9, 2023

alber70g Nov 8, 2023

alber70g Nov 8, 2023

alber70g Nov 8, 2023

alber70g Nov 8, 2023

alber70g Nov 8, 2023

alber70g Nov 8, 2023 •

edited

Loading

alber70g Nov 8, 2023 •

edited

Loading

	"description": "HD Wallet; key derivation",
	"description": "A common approach to work with mnemonic keys and key derivation for Kadena based on BIP39 BIP44",


		export declare const kadenaGenMnemonic: () => string;

		export declare const kadenaGetPublic: (secretKey: Uint8Array) => Uint8Array;

feat(hd-wallet): add package #1151

feat(hd-wallet): add package #1151

Conversation

javadkh2 commented Oct 31, 2023

changeset-bot bot commented Oct 31, 2023 • edited Loading

🦋 Changeset detected

vercel bot commented Oct 31, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

alber70g Nov 8, 2023 • edited Loading

Choose a reason for hiding this comment

alber70g Nov 8, 2023 • edited Loading

Choose a reason for hiding this comment

changeset-bot bot commented Oct 31, 2023 •

edited

Loading

vercel bot commented Oct 31, 2023 •

edited

Loading

alber70g Nov 8, 2023 •

edited

Loading

alber70g Nov 8, 2023 •

edited

Loading