-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[@kadena/graph] Normalized error handling #1160
Conversation
🦋 Changeset detectedLatest commit: 1d36f9e The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 4 Ignored Deployments
|
Looks quite good to me 🙌🏽🙌🏽 |
There's some conflicts to be resolved, but apart from that everything looks good 🚀 🙌🏽 |
General remark: Should we maybe add a timeout to the subscriptions? I think all these are out of scope but just things I noticed while testing these changes. |
packages/apps/graph/src/index.ts
Outdated
@@ -1,23 +1,17 @@ | |||
require('module-alias/register'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this be done with import
?
require('module-alias/register'); | |
import('module-alias/register'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It can, but the auto sort for imports will move it down. For now it's okay, but it will break if an import is sorted above it that uses module aliases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah good one. Yes we can ignore the auto-fix I think?
This is one of the reasons we used to have a custom order. Sometimes you need a order when importing like that.
What happens when you use import 'module-alias/register'
?
This PR contains several things: