Use shared vitest config and enable thresholdAutoUpdate for some packages. #1169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ghislain89
requested review from
alber70g,
eileenmguo,
sstraatemans,
javadkh2,
Takadenoshi,
sanderlooijenga and
KristinaSpasevska
as code owners
🦋 Changeset detectedLatest commit: 3d5d02c The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 4 Ignored Deployments
|
sanderlooijenga
approved these changes
Nov 3, 2023
ash-vd
approved these changes
Nov 3, 2023
Ghislain89
force-pushed
the
test/code-coverage
branch
from
28a1ff4
to
dcfb0eb
Compare
alber70g
approved these changes
Nov 6, 2023
sstraatemans
approved these changes
Nov 6, 2023
Takadenoshi
approved these changes
Nov 6, 2023
eileenmguo
approved these changes
Nov 6, 2023
KristinaSpasevska
approved these changes
Nov 7, 2023
…enable threshold updater.
…able threshold updater.
…threshold updater.
… well as locally. Removing thresholdAutoUpdate for react-ui, for now.
Ghislain89
force-pushed
the
test/code-coverage
branch
from
eda126e
to
47c8be8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently vitest is configured to gather code coverage in CI as well as not run in watch mode. After various tests both of these do not seem to work correctly. This PR aims to fix this behaviour.
With this PR, all relevant packages now correctly depend on the shared vitest configuration and only override settings that are package specific. Code coverage is now collected again.
There are some packages that do not meet the globally defined criteria defined in the @kadena-dev/shared-config package. The current coverage levels have been set as baseline for these packages and ThresholdAutoUpdated has been enabled. As developers work to improve coverage, the baseline will be increased as well.
The following packages are impacted by this:
The result wil be that, gradually code coverage will be increased for packages that are touched often until they meet the globally defined defaults.