fix(client/signWithChainweaver) KIP-0015 update #156

ggobugi27 · 2023-02-02T06:54:39Z

Reason:

signWithChainweaver fails with Chainweaver 2.2.3 which uses the upgraded signing-api: kadena-io/signing-api#19, which changes the endpoint from /quickSign to /quicksign with request/response body changes.

Changes made (preferably with images/screenshots):

Update signWithChainweaver function to support the new signing-api, and add necessary interfaces
Fix IUnsignedSignatureWithHash to include {sig: null} option
Change pubkey in addSignatures in ICommandBuilder to pubKey
Update signWithChainweaver test

Check off the following:

[ V ] I have reviewed my changes and run the appropriate tests.
[ V ] I have have run rush change to add the appropriate change logs.
[ V ] I have added/edited docs.
[ X ] I have added tutorials.
[ X ] I have double checked and DEFINITELY added docs.

…inweaverResponse

packages/libs/client/src/pact.ts

packages/libs/client/src/signing/tests/signWithChainweaver.test.ts

packages/libs/client/src/pact.ts

packages/libs/client/src/signing/signWithChainweaver.ts

…unity/kadena.js into fix/update-quicksign

packages/libs/chainweb-node-client/src/tests/local.test.ts

packages/libs/chainweb-node-client/src/tests/send.test.ts

packages/libs/client/src/pact.ts

packages/libs/client/src/signing/signWithChainweaver.ts

packages/libs/client/src/signing/tests/signWithChainweaver.test.ts

packages/libs/pactjs-test-project/src/example-templates/generated-tx-templates/index.ts

…t.ts Co-authored-by: Albert G <516972+alber70g@users.noreply.github.com>

Co-authored-by: Albert G <516972+alber70g@users.noreply.github.com>

…unity/kadena.js into fix/update-quicksign

Co-authored-by: Albert G <516972+alber70g@users.noreply.github.com>

…Command

…unity/kadena.js into fix/update-quicksign

ggobugi27 added 2 commits February 2, 2023 15:41

update /quickSign to /quicksign

d484696

rush change

8fadb38

ggobugi27 requested review from alber70g, Randynamic and EnoF February 2, 2023 06:54

ggobugi27 changed the title ~~fix(client/signWithChainweaver) /quickSign to /quicksign~~ [WIP] fix(client/signWithChainweaver) /quickSign to /quicksign Feb 2, 2023

ggobugi27 changed the title ~~[WIP] fix(client/signWithChainweaver) /quickSign to /quicksign~~ [WIP] fix(client/signWithChainweaver) KIP-0015 updat Feb 2, 2023

ggobugi27 changed the title ~~[WIP] fix(client/signWithChainweaver) KIP-0015 updat~~ [WIP] fix(client/signWithChainweaver) KIP-0015 update Feb 2, 2023

nillo approved these changes Feb 2, 2023

View reviewed changes

ggobugi27 added 2 commits February 15, 2023 20:05

update requestBody

eac3f45

add null to ISignature, pubkey => pubKey in addSignatures, update Cha…

ad723e0

…inweaverResponse

EnoF reviewed Feb 16, 2023

View reviewed changes

packages/libs/client/src/pact.ts Outdated Show resolved Hide resolved

EnoF reviewed Feb 16, 2023

View reviewed changes

packages/libs/client/src/pact.ts Outdated Show resolved Hide resolved

EnoF reviewed Feb 16, 2023

View reviewed changes

packages/libs/client/src/signing/tests/signWithChainweaver.test.ts Outdated Show resolved Hide resolved

fix import and rewrite

981dafa

Randynamic previously requested changes Feb 17, 2023

View reviewed changes

packages/libs/client/src/pact.ts Outdated Show resolved Hide resolved

ggobugi27 added 2 commits February 17, 2023 22:53

update signWithChainweaver tests

8b5c60a

run rush change

202c362

ggobugi27 changed the title ~~[WIP] fix(client/signWithChainweaver) KIP-0015 update~~ fix(client/signWithChainweaver) KIP-0015 update Feb 17, 2023

minor fix

b6a9ea3

CryptoPascal31 reviewed Feb 17, 2023

View reviewed changes

packages/libs/client/src/signing/signWithChainweaver.ts Show resolved Hide resolved

ggobugi27 changed the title ~~fix(client/signWithChainweaver) KIP-0015 update~~ [WIP] fix(client/signWithChainweaver) KIP-0015 update Feb 17, 2023

ggobugi27 added 2 commits February 20, 2023 22:46

add failure / noSig cases in Chainweaver Response and Error

cfff536

add noSig case to the test

1984929

ggobugi27 changed the title ~~[WIP] fix(client/signWithChainweaver) KIP-0015 update~~ fix(client/signWithChainweaver) KIP-0015 update Feb 21, 2023

ggobugi27 added 5 commits February 21, 2023 20:07

handle nullable string value

377edcd

add eslint-disable to prevent null warning

63dde22

add eslint-disable-next-line for no-new-null errors

b9c5dbb

Merge branch 'fix/update-quicksign' of https://github.com/kadena-comm…

7732e68

…unity/kadena.js into fix/update-quicksign

remove eslint-disable

48e833b

ggobugi27 added 4 commits February 24, 2023 19:17

fix ISignature to non-null and use ISignatureJson

5c6a6b9

rush change

32e259b

merge master

03bbcb2

remove open-api generatioin

eb60fb3

alber70g requested review from nillo and Randynamic February 24, 2023 10:50

ggobugi27 added 2 commits February 24, 2023 20:05

add open-api

06fb490

update expected value in test

5472984

alber70g requested changes Feb 24, 2023

View reviewed changes

ggobugi27 and others added 13 commits February 24, 2023 20:52

Update packages/libs/client/src/signing/tests/signWithChainweaver.tes…

fc72866

…t.ts Co-authored-by: Albert G <516972+alber70g@users.noreply.github.com>

Update packages/libs/chainweb-node-client/src/tests/local.test.ts

69f6e0c

Co-authored-by: Albert G <516972+alber70g@users.noreply.github.com>

remove console.log

6e23872

Merge branch 'fix/update-quicksign' of https://github.com/kadena-comm…

c2f960d

…unity/kadena.js into fix/update-quicksign

add IQuicksignResponseBody

929df98

Update packages/libs/chainweb-node-client/src/tests/send.test.ts

9962020

Co-authored-by: Albert G <516972+alber70g@users.noreply.github.com>

revert to master

4489e46

Update index.ts

bbf964f

Update index.ts

13f0588

revert to master

6a0a13e

Update index.ts

07ab924

Update index.ts

a747ba2

chore: remove generated from openapi spec

4bf5e95

alber70g force-pushed the fix/update-quicksign branch from c2a015e to 4bf5e95 Compare February 24, 2023 14:17

alber70g added 2 commits February 24, 2023 15:59

chore: add type to differentiate between quicksign success and response

500aae2

fix(client): test with order when converting unsignedTransaction to I…

a9fc845

…Command

alber70g approved these changes Feb 24, 2023

View reviewed changes

ggobugi27 added 2 commits February 27, 2023 16:03

Merge branch 'fix/update-quicksign' of https://github.com/kadena-comm…

ad7b4e3

…unity/kadena.js into fix/update-quicksign

add test coverage

cf51b6c

ggobugi27 merged commit 60d89f5 into master Feb 27, 2023

ggobugi27 deleted the fix/update-quicksign branch February 27, 2023 12:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(client/signWithChainweaver) KIP-0015 update #156

fix(client/signWithChainweaver) KIP-0015 update #156

ggobugi27 commented Feb 2, 2023 •

edited

Loading

fix(client/signWithChainweaver) KIP-0015 update #156

fix(client/signWithChainweaver) KIP-0015 update #156

Conversation

ggobugi27 commented Feb 2, 2023 • edited Loading

Reason:

Changes made (preferably with images/screenshots):

Check off the following:

ggobugi27 commented Feb 2, 2023 •

edited

Loading