Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@kadena/chainweb-stream-client - Changed default export at index to named export #626

Merged
merged 5 commits into from
Oct 25, 2023

Conversation

Takadenoshi
Copy link
Contributor

@Takadenoshi Takadenoshi commented Jul 19, 2023

Default export didn't work with out CJS-targeted output

Also broke the example in the README

@vercel
Copy link

vercel bot commented Jul 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

6 Ignored Deployments
Name Status Preview Comments Updated (UTC)
alpha-docs ⬜️ Ignored (Inspect) Visit Preview Oct 3, 2023 2:13pm
docs-storybook ⬜️ Ignored (Inspect) Visit Preview Oct 3, 2023 2:13pm
immutable-records ⬜️ Ignored (Inspect) Visit Preview Oct 3, 2023 2:13pm
react-ui ⬜️ Ignored (Inspect) Visit Preview Oct 3, 2023 2:13pm
tools ⬜️ Ignored (Inspect) Visit Preview Oct 3, 2023 2:13pm
transfer ⬜️ Ignored (Inspect) Oct 3, 2023 2:13pm

@changeset-bot
Copy link

changeset-bot bot commented Oct 2, 2023

🦋 Changeset detected

Latest commit: cf8dfb3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@kadena/chainweb-stream-client Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Takadenoshi Takadenoshi changed the base branch from main to add-missing-colrs-icon-button-component October 2, 2023 11:25
@Takadenoshi Takadenoshi changed the base branch from add-missing-colrs-icon-button-component to main October 2, 2023 11:25
@Takadenoshi Takadenoshi force-pushed the chore/chainweb-stream-client-change-default-export branch from 5f47958 to 293914e Compare October 2, 2023 11:38
@Takadenoshi
Copy link
Contributor Author

This needs publishing, the 0.1.0 version that was published to npm from main overwrote the 0.0.10 version that had this fix

@webpro
Copy link
Contributor

webpro commented Oct 2, 2023

This needs publishing, the 0.1.0 version that was published to npm from main overwrote the 0.0.10 version that had this fix

  • We should not bump version ourselves manually (Changesets does this for us)
  • On the same note, we do need to make sure the changelog reflects the bump

I see minor in the changelog, but a patch bump in package.json#version

@Takadenoshi
Copy link
Contributor Author

  • I reverted the manual bump in package.json
  • I changed the changeset bump to a patch

Ideally I wanted to stay on 0.0.x for a while until it is a bit more stable but now we are on 0.1.x

@Takadenoshi Takadenoshi merged commit 1bf41db into main Oct 25, 2023
8 checks passed
@Takadenoshi Takadenoshi deleted the chore/chainweb-stream-client-change-default-export branch October 25, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants