Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Select component #782

Merged
merged 33 commits into from
Aug 29, 2023
Merged

Update Select component #782

merged 33 commits into from
Aug 29, 2023

Conversation

timoheddes
Copy link
Contributor

@timoheddes timoheddes commented Aug 14, 2023

Select Component updates

Asana Link

What changed?

  • Updated Select styling to match design and support dark and light theme
  • Tweaked the size of the native HTML select element that we render to ensure you can click anywhere on the actual Select component to see its options (previously required to click in the center of our visual component)
  • Added disabled styling (missing exact design, also missing in e.g. Input component?)
  • Add variant prop to allow switching between default form select and one with a solid border and transparent background
  • Set Tooltip z-index as a temporary fix to ensure it's above form elements (created task to fix this for all components)
  • Removed style from option elements as these can't be styled (?? not sure what the idea was there, am I missing something?)
  • Added typing to the Input component type to match valid HTML Input Types rather than any string and updated Storybook implementation to allow switching between input types

Implementation preview in Storybook, showing Input and Select:

Screen.Recording.2023-08-25.at.11.35.37.mov

@vercel
Copy link

vercel bot commented Aug 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 29, 2023 7:23am
4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
alpha-docs ⬜️ Ignored (Inspect) Visit Preview Aug 29, 2023 7:23am
docs-storybook ⬜️ Ignored (Inspect) Visit Preview Aug 29, 2023 7:23am
immutable-records ⬜️ Ignored (Inspect) Visit Preview Aug 29, 2023 7:23am
tools ⬜️ Ignored (Inspect) Visit Preview Aug 29, 2023 7:23am

eileenmguo

This comment was marked as resolved.

@timoheddes

This comment was marked as resolved.

@MRVDH

This comment was marked as resolved.

@timoheddes

This comment was marked as resolved.

@timoheddes timoheddes merged commit 372a0fe into main Aug 29, 2023
4 checks passed
@timoheddes timoheddes deleted the feat/update-select branch August 29, 2023 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants