Refactor Accordion [Composition pattern, optimisations, contributing standards]

[timoheddes]

⚠️ Please read before review ⚠️

There are a lot of changes. A lot of them are just related to making type imports and exports explicit, e.g. instead of:

import React, { FC } from 'react';

we do:

import type { FC } from 'react';
import React from 'react';

etc.

Not doing this causes warnings in your console. This change doesn't really require review. So, that leaves the primary refactor which is the Accordion component. In short, please focus on reviewing:

• Any changes outside of react-ui library
• Accordion in react-ui

---

General PR description

Asana task

This PR primarily aims to refactor Accordion to follow our standards regarding composition structure and other things. Other components like it will be updated in similar fashion in the future so that they all follow the same structure.

Updated Accordion preview

Screen.Recording.2023-08-29.at.10.02.32.mov

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
alpha-docs	🛑 Canceled (Inspect)			Aug 31, 2023 8:27am
docs-storybook	🛑 Canceled (Inspect)			Aug 31, 2023 8:27am
react-ui	🛑 Canceled (Inspect)			Aug 31, 2023 8:27am

2 Ignored Deployments

Name	Status	Preview	Comments	Updated (UTC)
immutable-records	⬜️ Ignored (Inspect)	Visit Preview		Aug 31, 2023 8:27am
tools	⬜️ Ignored (Inspect)	Visit Preview		Aug 31, 2023 8:27am

[eileenmguo]

Thanks for fixing the type warnings!! It's really good to get these taken care of :) In the future I would suggest creating a separate PR for them for the sake of separating concerns so we can merge changes as soon as their ready

[webpro]

Just saying, this is valid too:

import React, { type FC } from 'react';