From 2306a29f5c94cd3c7c0aeb85a1b053d936268e73 Mon Sep 17 00:00:00 2001 From: Mohamed Ismail Date: Mon, 21 Aug 2023 10:23:13 +0200 Subject: [PATCH 1/4] fix(docs): browse section ui fixes --- packages/apps/docs/src/pages/docs/kadena/index.tsx | 2 +- packages/apps/docs/src/pages/index.tsx | 2 +- packages/apps/docs/src/styles/index.css.ts | 12 ++++-------- 3 files changed, 6 insertions(+), 10 deletions(-) diff --git a/packages/apps/docs/src/pages/docs/kadena/index.tsx b/packages/apps/docs/src/pages/docs/kadena/index.tsx index 26f8a448fb..4b40abc5de 100644 --- a/packages/apps/docs/src/pages/docs/kadena/index.tsx +++ b/packages/apps/docs/src/pages/docs/kadena/index.tsx @@ -39,7 +39,7 @@ const Home: FC = () => { - + Overview of Kadena Whitepapers diff --git a/packages/apps/docs/src/pages/index.tsx b/packages/apps/docs/src/pages/index.tsx index 7f188fb1e2..d0e988fda7 100644 --- a/packages/apps/docs/src/pages/index.tsx +++ b/packages/apps/docs/src/pages/index.tsx @@ -34,7 +34,7 @@ const Home: FC = ({ popularPages }) => { >
- + Overview of Kadena Manage your KDA diff --git a/packages/apps/docs/src/styles/index.css.ts b/packages/apps/docs/src/styles/index.css.ts index 8543be4a2d..d92c8fb860 100644 --- a/packages/apps/docs/src/styles/index.css.ts +++ b/packages/apps/docs/src/styles/index.css.ts @@ -1,18 +1,14 @@ -import { breakpoints, sprinkles } from '@kadena/react-ui/theme'; +import { breakpoints, vars } from '@kadena/react-ui/theme'; import { style } from '@vanilla-extract/css'; const browseSectionWrapper = style([ - sprinkles({ - gap: '$4', - paddingY: 0, - paddingX: '$4', - }), { - flexBasis: '48%', + flexBasis: '50%', + rowGap: vars.sizes.$4, '@media': { [breakpoints.md]: { - flexBasis: '30%', + flexBasis: '33%', }, }, }, From 5e83fa0e9aae68bc31dfd007bfe16ee11043daae Mon Sep 17 00:00:00 2001 From: Mohamed Ismail Date: Mon, 21 Aug 2023 12:00:48 +0200 Subject: [PATCH 2/4] fix(docs): add an additional check for active element + href --- packages/apps/docs/src/pages/_app.tsx | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/packages/apps/docs/src/pages/_app.tsx b/packages/apps/docs/src/pages/_app.tsx index d520dac347..d2203278e3 100644 --- a/packages/apps/docs/src/pages/_app.tsx +++ b/packages/apps/docs/src/pages/_app.tsx @@ -54,7 +54,10 @@ export const MyApp = ({ const handleBeforeUnload = (event: BeforeUnloadEvent): void => { // eslint-disable-next-line @typescript-eslint/no-explicit-any - const { href } = (event as any).originalTarget.activeElement; + const { href } = (event as any).originalTarget?.activeElement || {}; + + if (!href) return; + onExternalButtonClick(href); }; From 43579999b6ebc5a6cd092abe8a0f199fe4d97b25 Mon Sep 17 00:00:00 2001 From: Mohamed Ismail Date: Tue, 22 Aug 2023 09:53:02 +0200 Subject: [PATCH 3/4] chore(docs): remove unused component --- packages/apps/docs/src/components/Layout/Landing/Landing.tsx | 2 -- packages/apps/docs/src/pages/docs/blogchain/index.tsx | 2 -- 2 files changed, 4 deletions(-) diff --git a/packages/apps/docs/src/components/Layout/Landing/Landing.tsx b/packages/apps/docs/src/components/Layout/Landing/Landing.tsx index fc1cada9de..d018068bd9 100644 --- a/packages/apps/docs/src/components/Layout/Landing/Landing.tsx +++ b/packages/apps/docs/src/components/Layout/Landing/Landing.tsx @@ -1,5 +1,4 @@ import { - Article, articleClass, contentClass, contentClassVariants, @@ -34,7 +33,6 @@ export const Landing: FC = ({ >
{children} -
diff --git a/packages/apps/docs/src/pages/docs/blogchain/index.tsx b/packages/apps/docs/src/pages/docs/blogchain/index.tsx index 2d46aaaf78..65354937c8 100644 --- a/packages/apps/docs/src/pages/docs/blogchain/index.tsx +++ b/packages/apps/docs/src/pages/docs/blogchain/index.tsx @@ -3,9 +3,7 @@ import { Stack } from '@kadena/react-ui'; import { InfiniteScroll } from '@/components'; import { BlogItem, BlogList } from '@/components/Blog'; import { - Article, articleClass, - Content, contentClass, contentClassVariants, TitleHeader, From 967d1c687fe9294f17b549fe5f043fb179af610e Mon Sep 17 00:00:00 2001 From: Mohamed Ismail Date: Tue, 22 Aug 2023 11:53:10 +0200 Subject: [PATCH 4/4] Revert "fix(docs): add an additional check for active element + href" This reverts commit 5e83fa0e9aae68bc31dfd007bfe16ee11043daae. --- packages/apps/docs/src/pages/_app.tsx | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/packages/apps/docs/src/pages/_app.tsx b/packages/apps/docs/src/pages/_app.tsx index d2203278e3..d520dac347 100644 --- a/packages/apps/docs/src/pages/_app.tsx +++ b/packages/apps/docs/src/pages/_app.tsx @@ -54,10 +54,7 @@ export const MyApp = ({ const handleBeforeUnload = (event: BeforeUnloadEvent): void => { // eslint-disable-next-line @typescript-eslint/no-explicit-any - const { href } = (event as any).originalTarget?.activeElement || {}; - - if (!href) return; - + const { href } = (event as any).originalTarget.activeElement; onExternalButtonClick(href); };