Feat/kadena tools/sidebar account transactions #806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
| transactionDetails?.chain, | ||
| }, | ||
| ]} | ||
| icon={ProductIcon.ReceiverInactive} |
There was a problem hiding this comment.
The icon should change according to the transfer status. If the transfer is complete then it should show the Receiver icon instead of ReceiverInactive
There was a problem hiding this comment.
The problem is that the API that I use (estats) only returns completed transfers it seems. So this PR is just to push the current work, even though it's not done yet. I am going to create tickets with everything that still needs to be refactored and completed
There was a problem hiding this comment.
Oh ok I see. Then maybe just replace the Icon with ProductIcon.Receiver (used for completed transfers)? And then all good :)
packages/apps/tools/src/pages/account/account-transactions/results/index.tsx
Outdated
Show resolved
Hide resolved
nil-amrutlal
approved these changes
Aug 21, 2023
KristinaSpasevska
approved these changes
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code for this page is not done yet. Midway PR.