-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No unused vars as errors #814
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
Does this now block the local build as well? Or is there a way to ignore that locally? It would be extremely annoying to be blocked by this during development. Let's say you want to try something out. You comment out a block of code, replace it with a |
This is why linting and building should be separate. Then you can still build. But I see we're not there yet. So let's wait with merging this one until #612 is merged first. |
6ca1bf2
to
f9dc61c
Compare
f9dc61c
to
513a422
Compare
🦋 Changeset detectedLatest commit: 38cda2b The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question about the changeset file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When we merge this file like this. Will all subsequent changesets not trigger a "missing" changeset, and inadvertently result in missing changeset entries when we release?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think so. Let's keep an eye on it.
As I think unused variables are not just warnings, but errors.