Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No unused vars as errors #814

Merged
merged 4 commits into from
Aug 31, 2023
Merged

No unused vars as errors #814

merged 4 commits into from
Aug 31, 2023

Conversation

webpro
Copy link
Contributor

@webpro webpro commented Aug 23, 2023

As I think unused variables are not just warnings, but errors.

@webpro webpro requested a review from alber70g as a code owner August 23, 2023 13:18
@vercel
Copy link

vercel bot commented Aug 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
alpha-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2023 9:27am
docs-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2023 9:27am
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
immutable-records ⬜️ Ignored (Inspect) Visit Preview Aug 30, 2023 9:27am
react-ui ⬜️ Ignored (Inspect) Visit Preview Aug 30, 2023 9:27am
tools ⬜️ Ignored (Inspect) Visit Preview Aug 30, 2023 9:27am

@alber70g
Copy link
Member

Does this now block the local build as well? Or is there a way to ignore that locally? It would be extremely annoying to be blocked by this during development.

Let's say you want to try something out. You comment out a block of code, replace it with a console.log, and build and run it. Now you're faced with a blocking error that a variable is unused. That's undesirable

@webpro
Copy link
Contributor Author

webpro commented Aug 24, 2023

Does this now block the local build as well? Or is there a way to ignore that locally? It would be extremely annoying to be blocked by this during development.

This is why linting and building should be separate. Then you can still build. But I see we're not there yet. So let's wait with merging this one until #612 is merged first.

@webpro webpro force-pushed the feat/no-unused-vars-as-errors branch from f9dc61c to 513a422 Compare August 29, 2023 18:38
@changeset-bot
Copy link

changeset-bot bot commented Aug 29, 2023

🦋 Changeset detected

Latest commit: 38cda2b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@alber70g alber70g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question about the changeset file

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When we merge this file like this. Will all subsequent changesets not trigger a "missing" changeset, and inadvertently result in missing changeset entries when we release?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so. Let's keep an eye on it.

@webpro webpro merged commit 0fd1adb into main Aug 31, 2023
5 checks passed
@webpro webpro deleted the feat/no-unused-vars-as-errors branch August 31, 2023 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants