Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS]chore: optimisation #971

Merged
merged 14 commits into from
Oct 2, 2023
Merged

[DOCS]chore: optimisation #971

merged 14 commits into from
Oct 2, 2023

Conversation

sstraatemans
Copy link
Contributor

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Sep 28, 2023

🦋 Changeset detected

Latest commit: 2620f48

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@kadena/docs Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Sep 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
alpha-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 2, 2023 11:27am
docs-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 2, 2023 11:27am
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
immutable-records ⬜️ Ignored (Inspect) Visit Preview Oct 2, 2023 11:27am
react-ui ⬜️ Ignored (Inspect) Visit Preview Oct 2, 2023 11:27am
tools ⬜️ Ignored (Inspect) Visit Preview Oct 2, 2023 11:27am

</ul>
);
};
export const AsideList = React.forwardRef<HTMLUListElement, IProps>(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixes a console warning

@@ -1,7 +1,7 @@
import { darkThemeClass } from '@kadena/react-ui/theme';

import { themes } from '@storybook/theming';
import { RouterContext } from 'next/dist/shared/lib/router-context'; // next 12
import { RouterContext } from 'next/dist/shared/lib/router-context.shared-runtime'; // next 13
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needed to fix the build after next update

@@ -1,7 +1,7 @@
import { getData } from './getData.mjs';
import path from 'path';

const omit = (obj, ...keysToOmit) =>
const omit = (obj, keysToOmit) =>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this makes sure we need a lot less data in the getstaticprops.
making the website much faster

@@ -68,7 +68,11 @@ export const BottomPageSection: FC<IProps> = ({
)}
</Stack>
<Divider />
<Stack justifyContent="space-between" width="100%">
<Stack
direction={{ xs: 'column', lg: 'row' }}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aligning the subscribe and the helpful component on mobile

@@ -20,6 +20,7 @@
"dependencies": {
"@kadena/react-ui": "workspace:*",
"@vanilla-extract/css": "1.12.0",
"mini-css-extract-plugin": "2.7.6",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for some reason this was not in this app. and it kills the build

pageExtensions: ['ts', 'tsx', 'js', 'jsx', 'md', 'mdx'],
reactStrictMode: true,
productionBrowserSourceMaps: true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are we enabling sourcemaps for prod?

@@ -60,6 +59,7 @@ export const MyApp = ({
<title>{props.frontmatter.title}</title>
<meta name="title" content={props.frontmatter.title} />
<meta name="description" content={props.frontmatter.description} />
<meta name="viewport" content="width=device-width, initial-scale=1" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👍🏽

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants