First setup for Tools E2E tests #996

Ghislain89 · 2023-10-05T13:20:50Z

This PR adds

Shared Playwright Configuration, to be consumed in dApps
E2E tests with limited mocking for tools dApp.
Shared Page Objects for re-usable components.
GitHub Actions for these tests

changeset-bot · 2023-10-05T13:20:54Z

🦋 Changeset detected

Latest commit: ac99ec0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel · 2023-10-05T13:20:58Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Ignored Deployments

Name	Status	Preview	Updated (UTC)
alpha-docs	⬜️ Ignored (Inspect)	Visit Preview	Oct 16, 2023 11:11am
docs-storybook	⬜️ Ignored (Inspect)	Visit Preview	Oct 16, 2023 11:11am
immutable-records	⬜️ Ignored (Inspect)	Visit Preview	Oct 16, 2023 11:11am
react-ui	⬜️ Ignored (Inspect)	Visit Preview	Oct 16, 2023 11:11am
tools	⬜️ Ignored (Inspect)	Visit Preview	Oct 16, 2023 11:11am

.github/workflows/e2e-tests.yaml

alber70g · 2023-10-16T09:59:33Z

packages/tools/e2e-tests/playwright.config.ts

+      ? process.env.PLAYWRIGHT_BASE_URL
+      : 'http://127.0.0.1:3000',
+    channel: 'chromium',
+    trace: `retain-on-failure`,


nitpick, can be without backticks

alber70g · 2023-10-16T10:00:41Z

packages/tools/e2e-tests/playwright.config.ts

+  webServer: {
+    command: `pnpm --filter ${process.env.TESTOBJECT} run start`,
+    url: 'http://127.0.0.1:3000',
+    reuseExistingServer: !process.env.CI,


What happens when this is an empty string? For clarity could be process.env.CI === undefined

Empty string assume false, but i'll change it either way to make it more clear.

alber70g · 2023-10-16T10:03:05Z

packages/tools/e2e-tests/src/helpers/mock.helper.ts

@@ -0,0 +1,18 @@
+import type { Page } from '@playwright/test';
+
+export default class MockHelper {


Can we use named exports, for easy importing and maintainability

alber70g · 2023-10-16T10:04:01Z

packages/tools/e2e-tests/src/page-objects/react-ui/navHeader.component.ts

@@ -0,0 +1,15 @@
+import type { Locator, Page } from '@playwright/test';
+
+export default class NavHeaderComponent {


Can we use named exports, for easy importing and maintainability

alber70g · 2023-10-16T10:04:05Z

packages/tools/e2e-tests/src/page-objects/react-ui/notificationContainer.component.ts

@@ -0,0 +1,19 @@
+import type { Locator, Page } from '@playwright/test';
+
+export default class NotificationContainerComponent {


Can we use named exports, for easy importing and maintainability

alber70g · 2023-10-16T10:04:18Z

packages/tools/e2e-tests/src/page-objects/tools-app/components/aside.component.ts

@@ -0,0 +1,13 @@
+import type { Page } from '@playwright/test';
+
+export default class AsideComponent {


Can we use named exports, for easy importing and maintainability

alber70g · 2023-10-16T10:04:21Z

packages/tools/e2e-tests/src/page-objects/tools-app/components/toolsHeader.component.ts

+export default class ToolsHeaderComponent extends NavHeaderComponent {
+  public networkCard: CardComponent;
+


Can we use named exports, for easy importing and maintainability

(Applies to all the others as well. I stopped adding the comment from here)

alber70g · 2023-10-16T10:08:02Z

packages/tools/e2e-tests/tsconfig.json

+  "extends": "./node_modules/@kadena-dev/heft-rig/tsconfig-base.json",
+  "compilerOptions": {
+    "types": ["node"],
+    "rootDir": "./",


Why we wouldn't have src as rootDir?

It wasn't the rootrdir before. Good Catch.

vercel bot deployed to Preview – react-ui October 6, 2023 10:46 View deployment

vercel bot deployed to Preview – tools October 6, 2023 10:50 View deployment

vercel bot deployed to Preview – react-ui October 6, 2023 12:51 View deployment

vercel bot deployed to Preview – react-ui October 6, 2023 12:54 View deployment

vercel bot deployed to Preview – tools October 6, 2023 12:58 View deployment

vercel bot deployed to Preview – tools October 9, 2023 13:42 View deployment

Ghislain89 force-pushed the test/e2e-tools branch from 78aec6b to 56c867a Compare October 9, 2023 13:58

vercel bot deployed to Preview – tools October 9, 2023 17:21 View deployment

vercel bot deployed to Preview – tools October 10, 2023 08:57 View deployment

vercel bot deployed to Preview – tools October 10, 2023 09:28 View deployment

vercel bot deployed to Preview – tools October 10, 2023 09:34 View deployment

vercel bot deployed to Preview – tools October 10, 2023 09:41 View deployment

Ghislain89 force-pushed the test/e2e-tools branch from 67c492e to 5b954fb Compare October 10, 2023 09:57

vercel bot deployed to Preview – react-ui October 10, 2023 12:02 View deployment

vercel bot deployed to Preview – tools October 10, 2023 13:35 View deployment

vercel bot deployed to Preview – tools October 10, 2023 13:49 View deployment

Ghislain89 commented Oct 10, 2023

View reviewed changes

.github/workflows/e2e-tests.yaml Show resolved Hide resolved

vercel bot deployed to Preview – tools October 11, 2023 10:12 View deployment

vercel bot deployed to Preview – tools October 11, 2023 10:16 View deployment

Ghislain89 force-pushed the test/e2e-tools branch from 7255a23 to 069a019 Compare October 11, 2023 10:29

Ghislain89 marked this pull request as ready for review October 11, 2023 10:30

Ghislain89 requested review from alber70g, eileenmguo, sstraatemans, timoheddes and webpro as code owners October 11, 2023 10:30

vercel bot deployed to Preview – tools October 11, 2023 10:33 View deployment

vercel bot deployed to Preview – tools October 11, 2023 12:11 View deployment

Ghislain89 added 23 commits October 16, 2023 12:03

Add comment to env variables.

ff50e8c

Move tests to seperate package and update GitHub Actions accordingly

f6f44fd

update workflow to start webserver again

0d4a3ca

update workflow to start webserver again

6cb0822

remove starting of tools dApp, let playwright do this.

569620e

remove starting of tools dApp, let playwright do this.

3c87ac0

remove starting of tools dApp, let playwright do this.

5e1ab63

move to src folder

2397603

update config

5b502bf

add heft rig package for e2e package

af652ae

add heft rig package for e2e package

992b1c3

sort package.json

b62db37

clean up

dff0379

clean up dependencies

4f52f22

Unformat git hub actions.

c6fa612

fix working directory for browser installation

30f9585

clean up github actions slightly

8d7b385

Formatting and make package private

bf96d7e

update to latest version of playwright

4cfc403

remove usage of test Id's and update tests to reflect this

21ae5b2

Formatting

7f65267

Add empty changeset

2d53b8e

remove wrongly added package

976d2c5

Ghislain89 force-pushed the test/e2e-tools branch from d066e7f to 976d2c5 Compare October 16, 2023 10:04

Update readme with standard header. To be improved in future PR's.

6858376

alber70g approved these changes Oct 16, 2023

View reviewed changes

Ghislain89 added 2 commits October 16, 2023 12:15

Prettier configuration fixes

f095214

Remove explicit typing from mocks, change default to named exports.

ac99ec0

Ghislain89 merged commit 672bd89 into main Oct 16, 2023
9 checks passed

Ghislain89 deleted the test/e2e-tools branch October 16, 2023 11:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

First setup for Tools E2E tests #996

First setup for Tools E2E tests #996

Ghislain89 commented Oct 5, 2023 •

edited

Loading

changeset-bot bot commented Oct 5, 2023 •

edited

Loading

vercel bot commented Oct 5, 2023 •

edited

Loading

alber70g Oct 16, 2023

Ghislain89 Oct 16, 2023

alber70g Oct 16, 2023

Ghislain89 Oct 16, 2023

alber70g Oct 16, 2023

alber70g Oct 16, 2023

alber70g Oct 16, 2023

alber70g Oct 16, 2023

alber70g Oct 16, 2023

alber70g Oct 16, 2023

Ghislain89 Oct 16, 2023 •

edited

Loading

		@@ -0,0 +1,18 @@
		import type { Page } from '@playwright/test';

		export default class MockHelper {

		@@ -0,0 +1,15 @@
		import type { Locator, Page } from '@playwright/test';

		export default class NavHeaderComponent {

		@@ -0,0 +1,19 @@
		import type { Locator, Page } from '@playwright/test';

		export default class NotificationContainerComponent {

		@@ -0,0 +1,13 @@
		import type { Page } from '@playwright/test';

		export default class AsideComponent {

		export default class ToolsHeaderComponent extends NavHeaderComponent {
		public networkCard: CardComponent;

First setup for Tools E2E tests #996

First setup for Tools E2E tests #996

Conversation

Ghislain89 commented Oct 5, 2023 • edited Loading

changeset-bot bot commented Oct 5, 2023 • edited Loading

🦋 Changeset detected

vercel bot commented Oct 5, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Ghislain89 Oct 16, 2023 • edited Loading

Choose a reason for hiding this comment

Ghislain89 commented Oct 5, 2023 •

edited

Loading

changeset-bot bot commented Oct 5, 2023 •

edited

Loading

vercel bot commented Oct 5, 2023 •

edited

Loading

Ghislain89 Oct 16, 2023 •

edited

Loading