Populate receive modal for accts with keyset-refs #648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mightybyte
suggested changes
May 19, 2021
| @@ -24,6 +24,7 @@ data TxBuilder = TxBuilder | |||
| -- ^ Presence or absence of a keyset may be used to determine transfer vs | |||
| -- transfer-create. If the keyset is present and the account already exists | |||
| -- you could choose to do either a transfer or a transfer-create. | |||
| , _txBuilder_keysetRef :: Maybe KeySetName | |||
There was a problem hiding this comment.
The TxBuilder type is very sensitive because it defines the serialization format that is used both by Chainweaver and by other parts of the ecosystem. We don't want keyset refs to be visible at this level, both for backwards compatibility reasons and because the low level details of keyset refs should be hidden from users of the TxBuilder. So I think we should back out the changes to this data type and make sure that Chainweaver resolves the keyset elsewhere, preserving the keyset interface.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.