Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

development to 20 chains #3

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

development to 20 chains #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions lib/TXG/Utils.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ cidFromText t = case readEither (T.unpack t) of

chainIds :: ChainwebVersion -> [ChainId]
chainIds Mainnet01 = ChainId <$> [0..9]
chainIds Development = ChainId <$> [0..9]
chainIds Development = ChainId <$> [0..19]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there some way we can make this automatically detect the number of chains? It would be nice to not have to worry about changing this in the future.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In theory, yes, but I am not sure if it's worth the dev time.

Ideally, chainweb-api, should provide all information about chainweb versions and all other tools (possibly even chainweb-node) should get it from there.

chainIds Testnet04 = ChainId <$> [0..9]

-- -------------------------------------------------------------------------- --
Expand Down Expand Up @@ -306,4 +306,3 @@ mempoolMember
-> [TransactionHash]
-> IO (Either ClientError [Bool])
mempoolMember m a v c txh = mempoolPost m a v c "/member" txh