Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we remove "unknown" as option in FoodAcquisitionLocationType? #35

Open
kaiiam opened this issue Sep 13, 2024 · 0 comments
Open
Labels
help wanted Extra attention is needed requires discussion

Comments

@kaiiam
Copy link
Owner

kaiiam commented Sep 13, 2024

As suggested by Amos Anim student at the Kumasi Food Science and Technology university as well as PTFI fellow, he believes MIFC should eliminate the "unknown" citing that

Compilers can fish out all these data should the need be. The "Unknown" option puts no constraints on them.

My response is that perhaps it's reasonable to do the spec currently has "other" and "unknown" (see https://kaiiam.github.io/mifc/FoodAcquisitionLocationType/). Note that these options were taken from a previous version of the PTFI metadata sheet. Its up for debate here and in similar situations that if you give vague options you tend to get lower quality annotations on the flip side if people don't know that level of granularity and not giving them an option prevents their data from being formatted in the standard.

In this case perhaps keeping one of other or unknown but not both is a better solution. Thoughts?

@kaiiam kaiiam added help wanted Extra attention is needed requires discussion labels Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed requires discussion
Projects
None yet
Development

No branches or pull requests

1 participant