Release support to 1.21.x #28
Conversation
kairoaraujo
force-pushed
the
ci_and_contributing
branch
from
7f7ee4a
to
a0599c9
Compare
| go test -covermode=count -coverprofile=count.out -v ./... | ||
| go test -covermode=count -coverprofile=count.out -v $(go list ./... | grep -v /docs-test/) | ||
|
|
||
| export PATH=$$PATH:`go env GOPATH`/bin; make -C rest-api test-doc |
There was a problem hiding this comment.
@kairoaraujo It looks like now that the test recipe eventually leads to a call to swag, the GitHub workflow is broken since the ubuntu-latest container shell environment can't find the swag command. See: https://github.com/kairoaraujo/goca/actions/runs/3142411740/jobs/5105977765
Which is confusing because it looks like the check_swag recipe which we depend on should handle this.
Checking the branch out and running the tests locally on my machine does indeed auto-magically download swag.
Perhaps it is something to do with how $PATH is handled in the ubuntu-latest container?
There was a problem hiding this comment.
Thank you @necheffa, I will find time to fix it this weekend :)
- Added tests in CI for testing the documentation changes not committed Closes #14 - Add details for contributing to the project CONTRIBUTING.md - Update for latest go version and dependencies Signed-off-by: Kairo de Araujo <kairo@kairo.eti.br>
kairoaraujo
force-pushed
the
ci_and_contributing
branch
from
a0599c9
to
8729b47
Compare
Signed-off-by: Kairo de Araujo <kairo@dearaujo.nl>
kairoaraujo
force-pushed
the
ci_and_contributing
branch
from
c5dabb3
to
75c0e1a
Compare
Signed-off-by: Kairo de Araujo <kairo@dearaujo.nl>
kairoaraujo
force-pushed
the
ci_and_contributing
branch
from
75c0e1a
to
fe2cc8d
Compare
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #28 +/- ##
==========================================
- Coverage 65.94% 56.08% -9.86%
==========================================
Files 2 2
Lines 323 460 +137
==========================================
+ Hits 213 258 +45
- Misses 69 163 +94
+ Partials 41 39 -2 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Kairo de Araujo <kairo@dearaujo.nl>
|
@necheffa, I think due the changes, we should release as 2.0.0, WDYT? |
kairoaraujo
changed the title
|
@kairoaraujo I think bumping to 2.0.0 makes sense. Looks like the API changed just a little. Should we then also add "v2" to the module path so that |
Added tests in CI for testing the documentation changes not committed
Closes Implement a better doc test #14
Add details for contributing to the project CONTRIBUTING.md
Signed-off-by: Kairo Araujo kairo@kairo.eti.br