add Qualcomm Snapdragon bootloader for Android. #471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you specify the whole format, not only its header? Having a non-implemented formats in the main repo does harm by creating a false impression that the format is specified, while it isn't. |
No, I cannot, as the contents could be anything: ELF files, proprietary Qualcomm formats, etc. |
|
At least splitting the file into chunks each one has a well-defined size and position is neeeded. I mean there should be instances using which we can get raw bytes for each chunk. |
generalmimon
requested changes
Apr 10, 2021
generalmimon
reviewed
Sep 2, 2021
archive/android_bootldr_qcom.ksy
Outdated
| - id: name | ||
| size: 64 | ||
| type: strz | ||
| encoding: UTF-8 |
There was a problem hiding this comment.
@armijnhemel Doesn't
kaitai_struct_formats/archive/android_asus_bootldr.ksy
Lines 14 to 15 in 82d9493
in fact apply here as well?
There was a problem hiding this comment.
Could very well be. I am not entirely sure though and perhaps it is a silly comment. All the files I have tested with so far had ASCII characters.
generalmimon
approved these changes
Sep 2, 2021
generalmimon
added a commit
to armijnhemel/kaitai_struct_formats
that referenced
this pull request
Sep 2, 2021
... per the same naming convention as used for kaitai-io#471
generalmimon
added a commit
that referenced
this pull request
Sep 2, 2021
* add Huawei Bootloader packed image format * huawei boot image: introduce version type, rewrite entries * android_img_huawei: rename to `android_bootldr_huawei` ... per the same naming convention as used for #471 * android_bootldr_huawei: shorten commit hash * android_bootldr_huawei: fix format description, link to samples * android_bootldr_huawei: fix indentation * android_bootldr_huawei: take `meta_hdr_sz` into account, rename headers * android_bootldr_huawei: make `image_version` a string, ASCII enc * android_bootldr_huawei: parse `body` in `image_hdr_entry`, rename fields * android_bootldr_huawei: add info where all factory images are Co-authored-by: Petr Pucil <petr.pucil@seznam.cz>
ZetaTwo
pushed a commit
to ZetaTwo/kaitai_struct_formats
that referenced
this pull request
May 17, 2022
* add Huawei Bootloader packed image format * huawei boot image: introduce version type, rewrite entries * android_img_huawei: rename to `android_bootldr_huawei` ... per the same naming convention as used for kaitai-io#471 * android_bootldr_huawei: shorten commit hash * android_bootldr_huawei: fix format description, link to samples * android_bootldr_huawei: fix indentation * android_bootldr_huawei: take `meta_hdr_sz` into account, rename headers * android_bootldr_huawei: make `image_version` a string, ASCII enc * android_bootldr_huawei: parse `body` in `image_hdr_entry`, rename fields * android_bootldr_huawei: add info where all factory images are Co-authored-by: Petr Pucil <petr.pucil@seznam.cz>
ZetaTwo
pushed a commit
to ZetaTwo/kaitai_struct_formats
that referenced
this pull request
May 17, 2022
* add Huawei Bootloader packed image format * huawei boot image: introduce version type, rewrite entries * android_img_huawei: rename to `android_bootldr_huawei` ... per the same naming convention as used for kaitai-io#471 * android_bootldr_huawei: shorten commit hash * android_bootldr_huawei: fix format description, link to samples * android_bootldr_huawei: fix indentation * android_bootldr_huawei: take `meta_hdr_sz` into account, rename headers * android_bootldr_huawei: make `image_version` a string, ASCII enc * android_bootldr_huawei: parse `body` in `image_hdr_entry`, rename fields * android_bootldr_huawei: add info where all factory images are Co-authored-by: Petr Pucil <petr.pucil@seznam.cz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This file processes the header of the Qualcomm Snapdragon boot loader as used on some Android devices.