Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create dynamic testimonials #130

Open
1 of 4 tasks
ifirmawan opened this issue Sep 10, 2023 · 0 comments · May be fixed by #131
Open
1 of 4 tasks

Create dynamic testimonials #130

ifirmawan opened this issue Sep 10, 2023 · 0 comments · May be fixed by #131
Assignees
@ifirmawan @masovin

Comments

@ifirmawan
Copy link
Member

ifirmawan commented Sep 10, 2023 •
edited
Loading

TODO/DONE

Iwan

  • api/reviews/

Muhrofin

  • Implement /api/reviews/ in testimonials component
  • Fix lint issues
  • Fix prettier issues

lint issues

./pages/portfolio.jsx
50:15  Error: `'` can be escaped with `'`, `‘`, `'`, `’`.  react/no-unescaped-entities
59:16  Error: `'` can be escaped with `'`, `‘`, `'`, `’`.  react/no-unescaped-entities

./components/Projects.jsx
124:15  Error: Missing "key" prop for element in iterator  react/jsx-key

./components/Testimony.jsx
72:13  Error: Missing "key" prop for element in iterator  react/jsx-key
@ifirmawan ifirmawan self-assigned this Sep 10, 2023
@ifirmawan ifirmawan changed the title Create Testimonials API Create dynamic testimonials Sep 10, 2023
ifirmawan added a commit that referenced this issue Sep 10, 2023
@ifirmawan
[#130] Create json for data reviews
ac3f09a
ifirmawan added a commit that referenced this issue Sep 10, 2023
@ifirmawan
[#130] Create index reviews API
42c6f59
@ifirmawan ifirmawan linked a pull request Sep 10, 2023 that will close this issue
Draft
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ifirmawan ifirmawan

@masovin masovin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

130 create testimonials kakadigi/kakadigi.github.io
2 participants
@ifirmawan @masovin