Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forbid unsafe code #13

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Forbid unsafe code #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,8 @@
//! buffer or `Reader` (thanks to the change of `Value::Undefined`
//! and `Value::Ascii` described above).

#![forbid(unsafe_code)]
Copy link

@itudoben itudoben Jun 11, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason why unsafe code should be forbidden?

From geiger crate author, it looks like it's up to the user to decide.
It is, however, the opinion of the author of this project that libraries choosing to abstain from unsafe Rust usage when possible should be promoted.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you don't use unsafe code, then you should forbid it, as it makes cargo geiger's job easier, it makes it clearer that you're not using unsafe anywhere, and there are some things that are unsafe but you don't put an unsafe keyword around, and forbid(unsafe_code) forbids those.

Of course, if you do need unsafe code for a good reason, you can't do that.


pub use error::Error;
pub use jpeg::get_exif_attr as get_exif_attr_from_jpeg;
pub use reader::{Exif, Reader};
Expand Down