Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn on finished span in runWithSpan #936

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Warn on finished span in runWithSpan #936

wants to merge 1 commit into from

Conversation

SimunKaracic
Copy link
Contributor

No description provided.

@SimunKaracic SimunKaracic force-pushed the warn-when-running-finished-span branch 2 times, most recently from 367d3bb to b7cec7e Compare February 2, 2021 13:17
@ivantopo
Copy link
Contributor

ivantopo commented Feb 2, 2021

Given that this issue is related to the comments on #913, I wouldn't limit the warnings to runWithSpan. There are many ways we could be interacting with finished Spans, so I would rather put these things on the tag methods on the Span class itself.

And this opens two questions:

  • What do we do with Empty and Remote spans. I'm guessing they should also get warning.
  • Should the warning be there all the time or should we have a specific flag for it? I'm inclined to believe this should be behind some sort of debug flag.

@SimunKaracic
Add debug flag to kamon.tracing
7c5d817 
When enabled, will warn when trying to change closed spans
@SimunKaracic SimunKaracic force-pushed the warn-when-running-finished-span branch from b7cec7e to 7c5d817 Compare March 17, 2021 12:59
@SimunKaracic
Copy link
Contributor Author

Added flag, and a bunch of log messages everywhere.
Not sure if this is how you wanted it to look @ivantopo , so please check it out and let me know if you like it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SimunKaracic @ivantopo