-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce account repository #540
Labels
Comments
zaychenko-sergei
added
enhancement
New feature or request
rust
Pull requests that update Rust code
labels
Mar 6, 2024
This was referenced Mar 6, 2024
Closed
|
sergiimk
changed the title
Introduce repository of real Account IDs
Introduce account repository
Mar 14, 2024
6 tasks
6 tasks
zaychenko-sergei
added a commit
that referenced
this issue
May 4, 2024
…#566 Added in-memory account repository implementation and stabilized tests GitHub: extracting `id` Moved all authentication features to `kamu-accounts` domain Storing Github ID => AccountID correspondence in a separate table. Unified data model for accounts in all databases. Unified accounts repository tests Added test for Accounts.byId GraphQL query GraphQL: support resolving datasets by id Auto-registering predefined accounts in repository Correcting CLI flows (auto-registration). Replaced AccountName on AccountID in flow system (triggers) Smarter account configuration defaults Minimized use of default account's properties Review: avoid AccountIdSqlx wrapper via optional dependency in `opendatafabric` Added `podman-clean` utility to makefile Force installing of 'cargo-nextest' Support actual password checking and configuring passwords in .kamuconfig Tests for password hash and GitHub record repositories. Persistent implementation of password hash repositories for all 3 dbs. Review: LoginResponse should not return account Review: clarified API for get* and find* accounts Review: no longer need to record provider credentials into access tokens Review: removed obsolete 'allow-login-unknown' option Removed 'AccountTypeSqlx' wrapper as redundand Review: restructured responsibilities between providers and authentication services - only the service can decide whether to register an account. Remodeled GitHub account association more universally, introduced "provider_identity_key" mechanism. Silent login command. Tests: access tokens extensions Review: generalized `kamu login github` to `kamu login oauth` Tests: HTTP login and token validation Spawn blocking tasks for password hash/verify operations CI: disable Spark/Flink tests due to disk space issues Minor dependency updates Handling duplicate key violations in account repository
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
AuthenticationRepository:
AuthenticationService: find by AccountID operation:
CLI AccountService should use real AccountIDs:
OAuthGithub should interact to extract real AccountID:
CurrentAccountSubject:
(REEVALUATE) Token store (kamu login) should store AccountID instead / in addition to name
GraphQL API adjustments:
Remove hard-coded dummy IDs:
kamu-cli
- set fixed DIDs for users in config instead of fakedNote - UI impact (separate tickets):
- [x] Apollo InMemoryCache: user IDs for
Account
orAccountRef
.- [ ] Flow filters by account id instead of account name (separate ticket)
- [ ] Search by users - kamu-data/kamu-node#64
The text was updated successfully, but these errors were encountered: