Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simlified structure patterns for irrelevant fields #487

Merged
merged 1 commit into from
Feb 5, 2024
Merged

Simlified structure patterns for irrelevant fields #487

merged 1 commit into from
Feb 5, 2024

Conversation

zaychenko-sergei
Copy link
Contributor

@zaychenko-sergei zaychenko-sergei commented Feb 4, 2024 •
edited
Loading

Description

Inspired by reading "Programming Rust" book.

Checklist before requesting a review

  • CHANGELOG.md updated
  • API changes are backwards-compatible
  • Workspace layout changes include a migration
  • Documentation update PR: <link or N/A>
  • Dataset pipelines update scheduled if needed

@zaychenko-sergei
Copy link
Contributor Author

@sergiimk I enjoy this fix for assert_matches! case, this finally added sense to those matchers, where one could ignore variative fields that are irrelevant of for the test.

s373r
s373r approved these changes Feb 5, 2024
View reviewed changes
Copy link
Member

@s373r s373r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, it's easier to read now

@zaychenko-sergei zaychenko-sergei merged commit 7111ad8 into master Feb 5, 2024
5 checks passed
@zaychenko-sergei zaychenko-sergei deleted the experiment/rust-cleanups branch February 5, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergiimk sergiimk sergiimk approved these changes

@s373r s373r s373r approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zaychenko-sergei @sergiimk @s373r