Kamu 172 set polling source add prepare/preprocess from UI

src/app/auth/account/additional-components/datasets-tab/datasets-tab.component.spec.ts

@@ -11,6 +11,7 @@ import { NgbPopoverModule, NgbRatingModule } from "@ng-bootstrap/ng-bootstrap";
 import { DisplayTimeModule } from "src/app/components/display-time/display-time.module";
 import { MatChipsModule } from "@angular/material/chips";
 import { MatDividerModule } from "@angular/material/divider";
+import { SharedTestModule } from "src/app/common/shared-test.module";
 
 describe("DatasetsTabComponent", () => {
     let component: DatasetsTabComponent;
@@ -26,6 +27,7 @@ describe("DatasetsTabComponent", () => {
                 MatChipsModule,
                 NgbPopoverModule,
                 MatDividerModule,
+                SharedTestModule,
             ],
             providers: [DatasetApi],
             declarations: [DatasetsTabComponent, DatasetListItemComponent],

src/app/common/app.values.ts

@@ -10,6 +10,7 @@ export default class AppValues {
     public static readonly URL_PATTERN = /^(http:\/\/)|(https:\/\/)/i;
     public static readonly SCHEMA_NAME_PATTERN =
         /^[a-zA-Z0-9]+[a-zA-Z0-9\s(_)]*$/i;
+    public static readonly SPLIT_ARGUMENTS_PATTERN = /\w+|"[^"]+"/g;
 
     public static readonly DISPLAY_DATE_FORMAT = "DD MMM YYYY";
     public static readonly DISPLAY_TOOLTIP_DATE_FORMAT = "MMM D, YYYY, HH:mm A";

src/app/common/base.component.ts

@@ -1,7 +1,27 @@
+import { inject } from "@angular/core";
+import { ActivatedRoute, ParamMap } from "@angular/router";
+import { DatasetInfo } from "../interface/navigation.interface";
+import ProjectLinks from "../project-links";
+import { requireValue } from "./app.helpers";
 import { UnsubscribeOnDestroyAdapter } from "./unsubscribe.ondestroy.adapter";
 
 export abstract class BaseComponent extends UnsubscribeOnDestroyAdapter {
+    public activatedRoute = inject(ActivatedRoute);
+
     public get searchString(): string {
         return window.location.search;
     }
+
+    public getDatasetInfoFromUrl(): DatasetInfo {
+        const paramMap: ParamMap = this.activatedRoute.snapshot.paramMap;
+        return {
+            // Both parameters are mandatory in URL, router would not activate this component otherwise
+            accountName: requireValue(
+                paramMap.get(ProjectLinks.URL_PARAM_ACCOUNT_NAME),
+            ),
+            datasetName: requireValue(
+                paramMap.get(ProjectLinks.URL_PARAM_DATASET_NAME),
+            ),
+        };
+    }
 }

src/app/common/base.processing.component.ts

@@ -6,19 +6,14 @@ import {
 } from "../dataset-view/dataset-view.interface";
 import { searchAdditionalButtonsEnum } from "../search/search.interface";
 import { NavigationService } from "./../services/navigation.service";
-import { promiseWithCatch, requireValue } from "./app.helpers";
+import { promiseWithCatch } from "./app.helpers";
 import { BaseComponent } from "./base.component";
-import { ActivatedRoute, ParamMap } from "@angular/router";
-import ProjectLinks from "../project-links";
+import { inject } from "@angular/core";
 
 export class BaseProcessingComponent extends BaseComponent {
-    constructor(
-        protected navigationService: NavigationService,
-        protected modalService: ModalService,
-        protected activatedRoute: ActivatedRoute,
-    ) {
-        super();
-    }
+    public navigationService = inject(NavigationService);
+    public modalService = inject(ModalService);
+
     public showOwnerPage(ownerName: string): void {
         this.navigationService.navigateToOwnerView(ownerName);
     }
@@ -90,17 +85,4 @@ export class BaseProcessingComponent extends BaseComponent {
     private onClickDeriveFrom(): void {
         console.log("onClickDeriveFrom");
     }
-
-    public getDatasetInfoFromUrl(): DatasetInfo {
-        const paramMap: ParamMap = this.activatedRoute.snapshot.paramMap;
-        return {
-            // Both parameters are mandatory in URL, router would not activate this component otherwise
-            accountName: requireValue(
-                paramMap.get(ProjectLinks.URL_PARAM_ACCOUNT_NAME),
-            ),
-            datasetName: requireValue(
-                paramMap.get(ProjectLinks.URL_PARAM_DATASET_NAME),
-            ),
-        };
-    }
 }

src/app/common/shared-test.module.ts

@@ -0,0 +1,7 @@
+import { NgModule } from "@angular/core";
+import { snapshotParamMapMock } from "./base-test.helpers.spec";
+
+@NgModule({
+    providers: [snapshotParamMapMock],
+})
+export class SharedTestModule {}

src/app/components/dataset-list-item/dataset-list-item.component.spec.ts

@@ -10,6 +10,7 @@ import { emitClickOnElementByDataTestId } from "src/app/common/base-test.helpers
 import { DisplayTimeModule } from "../display-time/display-time.module";
 import { HttpClientTestingModule } from "@angular/common/http/testing";
 import { AngularSvgIconModule } from "angular-svg-icon";
+import { SharedTestModule } from "src/app/common/shared-test.module";
 
 describe("DatasetListItemComponent", () => {
     let component: DatasetListItemComponent;
@@ -28,6 +29,7 @@ describe("DatasetListItemComponent", () => {
                 DisplayTimeModule,
                 AngularSvgIconModule.forRoot(),
                 HttpClientTestingModule,
+                SharedTestModule,
             ],
         }).compileComponents();
 

src/app/components/display-time/display-time.component.spec.ts

@@ -2,6 +2,7 @@ import { ComponentFixture, TestBed } from "@angular/core/testing";
 import timekeeper from "timekeeper";
 
 import { DisplayTimeComponent } from "./display-time.component";
+import { SharedTestModule } from "src/app/common/shared-test.module";
 
 describe("DisplayTimeComponent", () => {
     let component: DisplayTimeComponent;
@@ -24,6 +25,7 @@ describe("DisplayTimeComponent", () => {
     beforeEach(async () => {
         await TestBed.configureTestingModule({
             declarations: [DisplayTimeComponent],
+            imports: [SharedTestModule],
         }).compileComponents();
 
         fixture = TestBed.createComponent(DisplayTimeComponent);

src/app/dataset-block/metadata-block/components/block-header/block-header.component.spec.ts

@@ -6,6 +6,7 @@ import { ComponentFixture, TestBed } from "@angular/core/testing";
 import { BlockHeaderComponent } from "./block-header.component";
 import { Apollo } from "apollo-angular";
 import { MatMenuModule } from "@angular/material/menu";
+import { SharedTestModule } from "src/app/common/shared-test.module";
 
 describe("BlockHeaderComponent", () => {
     let component: BlockHeaderComponent;
@@ -14,7 +15,12 @@ describe("BlockHeaderComponent", () => {
     beforeEach(async () => {
         await TestBed.configureTestingModule({
             declarations: [BlockHeaderComponent],
-            imports: [MatMenuModule, MatIconModule, MatDividerModule],
+            imports: [
+                MatMenuModule,
+                MatIconModule,
+                MatDividerModule,
+                SharedTestModule,
+            ],
             providers: [Apollo, DatasetApi],
         }).compileComponents();
 

src/app/dataset-block/metadata-block/components/event-details/components/add-data-event/add-data-event.component.spec.ts

@@ -13,7 +13,7 @@ import { HttpClientTestingModule } from "@angular/common/http/testing";
 import { TooltipIconComponent } from "../../../tooltip-icon/tooltip-icon.component";
 import { MatIconModule } from "@angular/material/icon";
 import { NgbTooltipModule } from "@ng-bootstrap/ng-bootstrap";
-import { snapshotParamMapMock } from "src/app/common/base-test.helpers.spec";
+import { SharedTestModule } from "src/app/common/shared-test.module";
 
 describe("AddDataEventComponent", () => {
     let component: AddDataEventComponent;
@@ -37,7 +37,6 @@ describe("AddDataEventComponent", () => {
                 BlockRowDataComponent,
                 TooltipIconComponent,
             ],
-            providers: [snapshotParamMapMock],
             imports: [
                 DisplaySizeModule,
                 ApolloModule,
@@ -46,6 +45,7 @@ describe("AddDataEventComponent", () => {
                 ToastrModule.forRoot(),
                 AngularSvgIconModule.forRoot(),
                 HttpClientTestingModule,
+                SharedTestModule,
             ],
         })
             .overrideComponent(AddDataEventComponent, {

src/app/dataset-block/metadata-block/components/event-details/components/common/block-interval-property/block-interval-property.component.spec.ts

@@ -8,6 +8,7 @@ import { DisplayHashModule } from "src/app/components/display-hash/dispaly-hash.
 import { ToastrModule } from "ngx-toastr";
 import { HttpClientTestingModule } from "@angular/common/http/testing";
 import { AngularSvgIconModule } from "angular-svg-icon";
+import { SharedTestModule } from "src/app/common/shared-test.module";
 
 describe("BlockIntervalPropertyComponent", () => {
     let component: BlockIntervalPropertyComponent;
@@ -23,6 +24,7 @@ describe("BlockIntervalPropertyComponent", () => {
                 ToastrModule.forRoot(),
                 AngularSvgIconModule.forRoot(),
                 HttpClientTestingModule,
+                SharedTestModule,
             ],
         }).compileComponents();
 

src/app/dataset-block/metadata-block/components/event-details/components/common/cache-property/cache-property.component.spec.ts

@@ -1,6 +1,6 @@
 import { ComponentFixture, TestBed } from "@angular/core/testing";
-
 import { CachePropertyComponent } from "./cache-property.component";
+import { SharedTestModule } from "src/app/common/shared-test.module";
 
 describe("CachePropertyComponent", () => {
     let component: CachePropertyComponent;
@@ -9,6 +9,7 @@ describe("CachePropertyComponent", () => {
     beforeEach(async () => {
         await TestBed.configureTestingModule({
             declarations: [CachePropertyComponent],
+            imports: [SharedTestModule],
         }).compileComponents();
 
         fixture = TestBed.createComponent(CachePropertyComponent);

src/app/dataset-block/metadata-block/components/event-details/components/common/cards-property/cards-property.component.spec.ts

@@ -1,6 +1,7 @@
 import { ComponentFixture, TestBed } from "@angular/core/testing";
 
 import { CardsPropertyComponent } from "./cards-property.component";
+import { ActivatedRoute } from "@angular/router";
 
 describe("CardsPropertyComponent", () => {
     let component: CardsPropertyComponent;
@@ -9,6 +10,25 @@ describe("CardsPropertyComponent", () => {
     beforeEach(async () => {
         await TestBed.configureTestingModule({
             declarations: [CardsPropertyComponent],
+            providers: [
+                {
+                    provide: ActivatedRoute,
+                    useValue: {
+                        snapshot: {
+                            paramMap: {
+                                get: (key: string) => {
+                                    switch (key) {
+                                        case "accountName":
+                                            return "accountName";
+                                        case "datasetName":
+                                            return "datasetName";
+                                    }
+                                },
+                            },
+                        },
+                    },
+                },
+            ],
         }).compileComponents();
 
         fixture = TestBed.createComponent(CardsPropertyComponent);

src/app/dataset-block/metadata-block/components/event-details/components/common/command-property/command-property.component.spec.ts

@@ -1,6 +1,6 @@
 import { ComponentFixture, TestBed } from "@angular/core/testing";
-
 import { CommandPropertyComponent } from "./command-property.component";
+import { SharedTestModule } from "src/app/common/shared-test.module";
 
 describe("CommandPropertyComponent", () => {
     let component: CommandPropertyComponent;
@@ -9,6 +9,7 @@ describe("CommandPropertyComponent", () => {
     beforeEach(async () => {
         await TestBed.configureTestingModule({
             declarations: [CommandPropertyComponent],
+            imports: [SharedTestModule],
         }).compileComponents();
 
         fixture = TestBed.createComponent(CommandPropertyComponent);

src/app/dataset-block/metadata-block/components/event-details/components/common/dataset-name-by-id-property/dataset-name-by-id-property.component.spec.ts

@@ -6,6 +6,7 @@ import { DatasetNameByIdPropertyComponent } from "./dataset-name-by-id-property.
 import { of } from "rxjs";
 import { DatasetService } from "src/app/dataset-view/dataset.service";
 import { mockDatasetMainDataResponse } from "src/app/search/mock.data";
+import { SharedTestModule } from "src/app/common/shared-test.module";
 
 describe("DatasetIdAndNamePropertyComponent", () => {
     let component: DatasetNameByIdPropertyComponent;
@@ -20,7 +21,7 @@ describe("DatasetIdAndNamePropertyComponent", () => {
     beforeEach(async () => {
         await TestBed.configureTestingModule({
             declarations: [DatasetNameByIdPropertyComponent],
-            imports: [ApolloTestingModule],
+            imports: [ApolloTestingModule, SharedTestModule],
         }).compileComponents();
 
         fixture = TestBed.createComponent(DatasetNameByIdPropertyComponent);

src/app/dataset-block/metadata-block/components/event-details/components/common/dataset-name-property/dataset-name-property.component.spec.ts

@@ -2,6 +2,7 @@ import { NavigationService } from "./../../../../../../../services/navigation.se
 import { ComponentFixture, TestBed } from "@angular/core/testing";
 import { DatasetNamePropertyComponent } from "./dataset-name-property.component";
 import { DatasetViewTypeEnum } from "src/app/dataset-view/dataset-view.interface";
+import { SharedTestModule } from "src/app/common/shared-test.module";
 
 describe("DatasetNamePropertyComponent", () => {
     let component: DatasetNamePropertyComponent;
@@ -11,6 +12,7 @@ describe("DatasetNamePropertyComponent", () => {
     beforeEach(async () => {
         await TestBed.configureTestingModule({
             declarations: [DatasetNamePropertyComponent],
+            imports: [SharedTestModule],
         }).compileComponents();
 
         fixture = TestBed.createComponent(DatasetNamePropertyComponent);

src/app/dataset-block/metadata-block/components/event-details/components/common/engine-property/engine-property.component.spec.ts

@@ -1,6 +1,6 @@
 import { ComponentFixture, TestBed } from "@angular/core/testing";
-
 import { EnginePropertyComponent } from "./engine-property.component";
+import { SharedTestModule } from "src/app/common/shared-test.module";
 
 describe("EnginePropertyComponent", () => {
     let component: EnginePropertyComponent;
@@ -9,6 +9,7 @@ describe("EnginePropertyComponent", () => {
     beforeEach(async () => {
         await TestBed.configureTestingModule({
             declarations: [EnginePropertyComponent],
+            imports: [SharedTestModule],
         }).compileComponents();
 
         fixture = TestBed.createComponent(EnginePropertyComponent);

src/app/dataset-block/metadata-block/components/event-details/components/common/env-variables-property/env-variables-property.component.spec.ts

@@ -2,6 +2,7 @@ import { ComponentFixture, TestBed } from "@angular/core/testing";
 import { EnvVariablesPropertyComponent } from "./env-variables-property.component";
 import { DynamicTableComponent } from "src/app/components/dynamic-table/dynamic-table.component";
 import { MatTableModule } from "@angular/material/table";
+import { SharedTestModule } from "src/app/common/shared-test.module";
 
 describe("EnvVariablesPropertyComponent", () => {
     let component: EnvVariablesPropertyComponent;
@@ -13,7 +14,7 @@ describe("EnvVariablesPropertyComponent", () => {
                 EnvVariablesPropertyComponent,
                 DynamicTableComponent,
             ],
-            imports: [MatTableModule],
+            imports: [MatTableModule, SharedTestModule],
         }).compileComponents();
 
         fixture = TestBed.createComponent(EnvVariablesPropertyComponent);

src/app/dataset-block/metadata-block/components/event-details/components/common/event-time-property/event-time-property.component.spec.ts

@@ -1,6 +1,6 @@
 import { ComponentFixture, TestBed } from "@angular/core/testing";
-
 import { EventTimePropertyComponent } from "./event-time-property.component";
+import { SharedTestModule } from "src/app/common/shared-test.module";
 
 describe("EventTimePropertyComponent", () => {
     let component: EventTimePropertyComponent;
@@ -9,6 +9,7 @@ describe("EventTimePropertyComponent", () => {
     beforeEach(async () => {
         await TestBed.configureTestingModule({
             declarations: [EventTimePropertyComponent],
+            imports: [SharedTestModule],
         }).compileComponents();
 
         fixture = TestBed.createComponent(EventTimePropertyComponent);

src/app/dataset-block/metadata-block/components/event-details/components/common/hash-property/hash-property.component.spec.ts

@@ -2,6 +2,7 @@ import { ComponentFixture, TestBed } from "@angular/core/testing";
 import { HashPropertyComponent } from "./hash-property.component";
 import { DisplayHashModule } from "src/app/components/display-hash/dispaly-hash.module";
 import { ToastrModule } from "ngx-toastr";
+import { SharedTestModule } from "src/app/common/shared-test.module";
 
 describe("HashPropertyComponent", () => {
     let component: HashPropertyComponent;
@@ -10,7 +11,11 @@ describe("HashPropertyComponent", () => {
     beforeEach(async () => {
         await TestBed.configureTestingModule({
             declarations: [HashPropertyComponent],
-            imports: [DisplayHashModule, ToastrModule.forRoot()],
+            imports: [
+                DisplayHashModule,
+                ToastrModule.forRoot(),
+                SharedTestModule,
+            ],
         }).compileComponents();
 
         fixture = TestBed.createComponent(HashPropertyComponent);

src/app/dataset-block/metadata-block/components/event-details/components/common/link-property/link-property.component.spec.ts

@@ -1,6 +1,6 @@
 import { ComponentFixture, TestBed } from "@angular/core/testing";
-
 import { LinkPropertyComponent } from "./link-property.component";
+import { SharedTestModule } from "src/app/common/shared-test.module";
 
 describe("LinkPropertyComponent", () => {
     let component: LinkPropertyComponent;
@@ -9,6 +9,7 @@ describe("LinkPropertyComponent", () => {
     beforeEach(async () => {
         await TestBed.configureTestingModule({
             declarations: [LinkPropertyComponent],
+            imports: [SharedTestModule],
         }).compileComponents();
 
         fixture = TestBed.createComponent(LinkPropertyComponent);

src/app/dataset-block/metadata-block/components/event-details/components/common/merge-strategy-property/merge-strategy-property.component.spec.ts

@@ -1,6 +1,6 @@
 import { ComponentFixture, TestBed } from "@angular/core/testing";
-
 import { MergeStrategyPropertyComponent } from "./merge-strategy-property.component";
+import { SharedTestModule } from "src/app/common/shared-test.module";
 
 describe("MergeStrategyPropertyComponent", () => {
     let component: MergeStrategyPropertyComponent;
@@ -9,6 +9,7 @@ describe("MergeStrategyPropertyComponent", () => {
     beforeEach(async () => {
         await TestBed.configureTestingModule({
             declarations: [MergeStrategyPropertyComponent],
+            imports: [SharedTestModule],
         }).compileComponents();
 
         fixture = TestBed.createComponent(MergeStrategyPropertyComponent);