-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kamu 180 add ability to rename and to delete dataset #120
Merged
zaychenko-sergei
merged 11 commits into
master
from
KAMU-180-Add-ability-to-rename-and-to-delete-dataset
Aug 18, 2023
Merged
Kamu 180 add ability to rename and to delete dataset #120
zaychenko-sergei
merged 11 commits into
master
from
KAMU-180-Add-ability-to-rename-and-to-delete-dataset
Aug 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitriy-borzenko
requested review from
sergiimk,
EvilAlexei and
zaychenko-sergei
August 16, 2023 18:44
EvilAlexei
reviewed
Aug 16, 2023
EvilAlexei
suggested changes
Aug 16, 2023
...p/dataset-view/additional-components/settings-component/services/dataset-settings.service.ts
Outdated
Show resolved
Hide resolved
src/app/dataset-view/additional-components/settings-component/settings.component.html
Outdated
Show resolved
Hide resolved
src/app/dataset-view/additional-components/settings-component/settings.component.html
Outdated
Show resolved
Hide resolved
...p/dataset-view/additional-components/settings-component/services/dataset-settings.service.ts
Show resolved
Hide resolved
zaychenko-sergei
requested changes
Aug 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't forget solid tests
...aset-view/additional-components/settings-component/services/dataset-settings.service.spec.ts
Outdated
Show resolved
Hide resolved
...p/dataset-view/additional-components/settings-component/services/dataset-settings.service.ts
Outdated
Show resolved
Hide resolved
zaychenko-sergei
approved these changes
Aug 18, 2023
zaychenko-sergei
deleted the
KAMU-180-Add-ability-to-rename-and-to-delete-dataset
branch
August 18, 2023 09:16
EvilAlexei
suggested changes
Aug 18, 2023
src/app/dataset-view/additional-components/settings-component/settings.component.sass
Show resolved
Hide resolved
src/app/dataset-view/additional-components/settings-component/settings.component.sass
Show resolved
Hide resolved
src/app/dataset-view/additional-components/settings-component/settings.component.sass
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.