Skip to content

Commit

Permalink
Merge pull request #13 from achmadhadikurnia/main
Browse files Browse the repository at this point in the history
Improvement and add contributings.md
  • Loading branch information
achmadhadikurnia authored Oct 25, 2023
2 parents 704113e + 99a24bf commit 1a9dca4
Show file tree
Hide file tree
Showing 3 changed files with 36 additions and 6 deletions.
27 changes: 27 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
# Contributing

Contributions are welcome and will be fully credited.

Contributions are accepted via Pull Requests on [Github](https://github.com/kanekescom/laravel-siasn-api).

# Things you could do
If you want to contribute but do not know where to start, this list provides some starting points.
- Add license text
- Remove rewriteRules.php
- Set up TravisCI, StyleCI, ScrutinizerCI
- Write a comprehensive ReadMe

## Pull Requests

- **Add tests!** - Your patch won't be accepted if it doesn't have tests.

- **Document any change in behaviour** - Make sure the `readme.md` and any other relevant documentation are kept up-to-date.

- **Consider our release cycle** - We try to follow [SemVer v2.0.0](http://semver.org/). Randomly breaking public APIs is not an option.

- **One pull request per feature** - If you want to do more than one thing, send multiple pull requests.

- **Send coherent history** - Make sure each individual commit in your pull request is meaningful. If you had to make multiple intermediate commits while developing, please [squash them](http://www.git-scm.com/book/en/v2/Git-Tools-Rewriting-History#Changing-Multiple-Commit-Messages) before submitting.


**Happy coding**!
1 change: 1 addition & 0 deletions src/Siasn.php
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ public function __construct()
$ssoToken = Token::getSsoToken();

$this->class = Http::retry(3, 100)
->timeout(10)
->withOptions([
'debug' => Config::getDebug(),
])->withHeaders([
Expand Down
14 changes: 8 additions & 6 deletions src/SiasnServiceProvider.php
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,14 @@ public function configurePackage(Package $package): void
$package
->name('laravel-siasn-api')
->hasConfigFile()
->hasCommand(Commands\ForgetTokenCommand::class)
->hasCommand(Commands\GenerateTokenCommand::class)
->hasCommand(Commands\GenerateApimTokenCommand::class)
->hasCommand(Commands\GenerateSsoTokenCommand::class)
->hasCommand(Commands\GetRequestEndpointCommand::class)
->hasCommand(Commands\PostRequestEndpointCommand::class);
->hasCommands([
Commands\ForgetTokenCommand::class,
Commands\GenerateTokenCommand::class,
Commands\GenerateApimTokenCommand::class,
Commands\GenerateSsoTokenCommand::class,
Commands\GetRequestEndpointCommand::class,
Commands\PostRequestEndpointCommand::class,
]);
}

public function packageRegistered(): void
Expand Down

0 comments on commit 1a9dca4

Please sign in to comment.