remove irb dep #749
remove irb dep #749
Conversation
mensfeld
added
the
enhancement
start stop benchmark (#752) optimize context switching in the jobs queue (#755) Partition revoked consumer action spec + fix (#758) ruby 3.1 support (#763) Restore code-reload support in development mode (#765) cleanup changelog rate limited integration spec + validator fix (#767) mfa (#769) LGPL update + Pro + License token verification (#770) gem bump check that there is no persistence (#771) 2.0 version fix Update CHANGELOG.md Infinite loop test case (#778) * seek loop integration spec * missing line * remarks common contracts base (#780) Improve ActiveJob setup (#779) fix invalid stop rule in integration spec lower concurrency for CI due to bundler spawning problem ensure, that all kafka keys are strings (#783) expose lag information in the batch headers (#785) Symbolize kafka keys (#786) WaterDrop 2.2 (#787) v2.0.0-alpha2 release (#788) update changelog Single message consumption mode integration spec for 2.0 (#792) * single message consumption abstraction integration spec * remarks Rails version railtie upgrade for Rails 5+ (#793) Installation flow fix + integration specs for standalone and Rails (#797) support initialized state and add integration for states flow (#799) v2.0.0.alpha3 (#800) add initial_offset option to define how to start listening (#801) lazy param deserialization spec (#808) Rails support without ActiveJob queue adapter usage (#805) gem bump Rename StdoutListener to LoggerListener (#816) update release date fix invalid error upon missing boot file + ensure stability of pristine specs (#819) update changelog cleaner integrations loop renamed event and consumption event integration spec (#822) improve rebalance manager (#823) do not fail when not first class citizen (#824) Optimize rebalancing behaviours (#826) optimize additional consumer shutdown in integration specs (#829) * optimize consumer shutdown in integration specs and optimize messages eviction * reorder spec Add static membership integration spec (#831) * wip * static membership integration spec * rubocop remarks update changelog
|
Not suggesting to add it back, but Rails 7.1 will have IRB as its dependency. The reason is that recent versions of IRB have received significant amount of enhancements and bug fixes between 2.7, 3.2, and the upcoming 3.3. By installing it as a gem, users in older Ruby versions can also get a decent experience in the console instead of getting stuck with an outdated one. We're also working on extension APIs to make it a better platform for gems to built their console with it. That being said, I'm aware that karafka-core still supports Ruby 2.6 while IRB is already considering dropping 2.7's support (due to YARP/Prism). So I just want to mention that there is and will be benefit of having IRB as a dependency despite it being a default gem 🙂 |
|
@st0012 thanks for the suggestion. Correct me if I'm wrong but can't user just define it himself if he wants? gem 'karafka'
gem 'irb'that way, once that want to have it slim will have it, but those that want newer will just use a newer one? |
irb is part of stdlib, thus it is not needed to include it in the gemfile