Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor font manager and implement bitmap font generator. #788

Merged
merged 10 commits into from
Jul 29, 2021

Conversation

andy840119
Copy link
Member

what's done in this pr:

  • refactor exist font manager and move into skin/fonts
  • move GetGlyphStore into font manager.
  • implement the bitmap font file generator, for compressing existing font files with remain target charset only.
  • implement the bitmap file image generator, for generating images with the font file.

and this shit only use in gameplay and editor (and config page).
placing it at root namespace might iet it feels too general.
not by game host.

also should register this manager.
Also add object assert fot compare two objects by parsing to json format.
also add testing for the case with generate multi line and multi page characters.
and add a test to make sure that it will generate same image as source.
@andy840119 andy840119 added skin About skin resource generator Auto-generator labels Jul 29, 2021
@andy840119 andy840119 added this to the 2021.0824 milestone Jul 29, 2021
@andy840119
Copy link
Member Author

Note: this is the big step in creating customize font in the skin.

@andy840119
Copy link
Member Author

andy840119 commented Jul 29, 2021

note:
it will cost 6~7 seconds in CI to generate a single image.

@andy840119 andy840119 merged commit d765318 into karaoke-dev:master Jul 29, 2021
@andy840119 andy840119 deleted the refactor-font-manager branch July 29, 2021 15:44
@andy840119
Copy link
Member Author

Also note that it's a big step for #787

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
generator Auto-generator size/XL skin About skin resource
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant