Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write tests #75

Open
karbassi opened this issue Jan 17, 2022 · 2 comments · May be fixed by #76
Open

Write tests #75

karbassi opened this issue Jan 17, 2022 · 2 comments · May be fixed by #76
Assignees
Milestone

Comments

@karbassi
Copy link
Owner

To bring this package up to standards, we need to have tests for each API call.

The API docs have definitions of what is required and optional and what is expected.

For example: https://dev.netatmo.com/apidocumentation/weather#getpublicdata

Name Type Required Default Description
lat_ne number Y latitude of the north east corner of the requested area. -85 <= lat_ne <= 85 and lat_ne>lat_sw
lon_ne number Y Longitude of the north east corner of the requested area. -180 <= lon_ne <= 180 and lon_ne>lon_sw
lat_sw number Y latitude of the south west corner of the requested area. -85 <= lat_sw <= 85
lon_sw number Y Longitude of the south west corner of the requested area. -180 <= lon_sw <= 180
required_data string N '' To filter stations based on relevant measurements you want (e.g. rain will only return stations with rain gauges). You can find all measurements available on the Thermostat page.
filter boolean N false True to exclude station with abnormal temperature measures.
@karbassi
Copy link
Owner Author

@floetenbaer is this something you can take on?

@karbassi karbassi added this to the v3.0.0 milestone Jan 17, 2022
@karbassi karbassi pinned this issue Jan 17, 2022
@floetenbaer
Copy link
Collaborator

@karbassi : uploaded new branch: feature/unit-test. What do you think about it?

@karbassi karbassi linked a pull request Jan 18, 2022 that will close this issue
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants