fix(ES-3297): lib-feature-flags: resolve typescript issue with the provider
#351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wkoszyk-karhoo
approved these changes
Jan 17, 2024
bkosm
deleted the
es-3297/fix/feature-flag-type-incompatible-with-provider
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered an issue migrating
web-lib-ops-toolingfrom the old feature flag package to this one.This snippet showcases it:
https://github.com/karhoo/web-lib-ops-tooling/pull/270/files#diff-5b588ba49ea45d9da53b56c9e6d2d1adc385bbb487a33398c958942944246591
The initializer class type is incompatible with the required
Providerproperty.