Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add api for cronjob resources #112

Merged
merged 2 commits into from
Sep 9, 2024

Conversation

warjiang
Copy link
Contributor

@warjiang warjiang commented Sep 8, 2024

What type of PR is this?
/kind design

What this PR does / why we need it:
Add api for cronjob resource management.
Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@karmada-bot karmada-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/design Categorizes issue or PR as related to design. labels Sep 8, 2024
@karmada-bot karmada-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Sep 8, 2024
@warjiang
Copy link
Contributor Author

warjiang commented Sep 8, 2024

api for cronjob depends on job, plz waiting for #111

@RainbowMango
Copy link
Member

Thanks for your hard work! Appreciated, you can rebase it now as #111 get merged.

Signed-off-by: warjiang <1096409085@qq.com>
Signed-off-by: warjiang <1096409085@qq.com>
@karmada-bot karmada-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 9, 2024
@warjiang
Copy link
Contributor Author

warjiang commented Sep 9, 2024

/status in-review

@warjiang warjiang changed the title WIP: add api for cronjob resources feat: add api for cronjob resources Sep 9, 2024
@karmada-bot karmada-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 9, 2024
@warjiang
Copy link
Contributor Author

warjiang commented Sep 9, 2024

Thanks for your hard work! Appreciated, you can rebase it now as #111 get merged.

Already rebase main branch, here we go~

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/assign

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 9, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 9, 2024
@karmada-bot karmada-bot merged commit 705986f into karmada-io:main Sep 9, 2024
4 checks passed
@warjiang warjiang deleted the feature/cronjob-api branch October 23, 2024 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/design Categorizes issue or PR as related to design. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants