-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: setup ci-workflow for PR #115
ci: setup ci-workflow for PR #115
Conversation
/assign @RainbowMango |
3013a1b
to
e6a017b
Compare
1180120
to
a39e1f5
Compare
@RainbowMango already rebased code, plz check this PR again~ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/assign
Don't have enough time today, probably tomorrow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good to me, Thanks.
Signed-off-by: warjiang <1096409085@qq.com>
ac1e704
to
7d68442
Compare
Co-authored-by: Hongcai Ren <renhongcai@huawei.com> Signed-off-by: warjiang <1096409085@qq.com>
7d68442
to
67c0388
Compare
I've already add the suggestion and cleaned up the commit msg, here we go @RainbowMango |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* ci: add all target in Makefile Signed-off-by: warjiang <1096409085@qq.com> * ci: add ci-workflow actions Co-authored-by: Hongcai Ren <renhongcai@huawei.com> Signed-off-by: warjiang <1096409085@qq.com> --------- Signed-off-by: warjiang <1096409085@qq.com> Co-authored-by: Hongcai Ren <renhongcai@huawei.com>
What type of PR is this?
/kind feature
What this PR does / why we need it:
some mock-case:
if contributor submit invalid goland code, like
the ci-workflow will report error like following:
if contributor submit invalid frontend code, like
the ci-workflow will report error like following:
Which issue(s) this PR fixes:
Fixes #102
Special notes for your reviewer:
Does this PR introduce a user-facing change?: