Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: setup ci-workflow for PR #115

Merged
merged 2 commits into from
Sep 11, 2024

Conversation

warjiang
Copy link
Contributor

@warjiang warjiang commented Sep 9, 2024

What type of PR is this?
/kind feature

What this PR does / why we need it:

  • precheck build error when contributor submit PR

some mock-case:

  1. if contributor submit invalid goland code, like
    image
    the ci-workflow will report error like following:
    image

  2. if contributor submit invalid frontend code, like
    image
    the ci-workflow will report error like following:
    image

Which issue(s) this PR fixes:
Fixes #102

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@karmada-bot karmada-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 9, 2024
@karmada-bot karmada-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Sep 9, 2024
@warjiang
Copy link
Contributor Author

warjiang commented Sep 9, 2024

/assign @RainbowMango

@warjiang
Copy link
Contributor Author

warjiang commented Sep 9, 2024

!!! this pr based #114
so we should resolve the pr#114

@warjiang warjiang force-pushed the ci/invoke-build-when-pr branch 2 times, most recently from 1180120 to a39e1f5 Compare September 10, 2024 08:51
@karmada-bot karmada-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 10, 2024
@warjiang
Copy link
Contributor Author

!!! this pr based #114 so we should resolve the pr#114

@RainbowMango already rebased code, plz check this PR again~

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/assign
Don't have enough time today, probably tomorrow.

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good to me, Thanks.

.github/workflows/ci.yml Outdated Show resolved Hide resolved
Signed-off-by: warjiang <1096409085@qq.com>
Co-authored-by: Hongcai Ren <renhongcai@huawei.com>
Signed-off-by: warjiang <1096409085@qq.com>
@warjiang
Copy link
Contributor Author

I've already add the suggestion and cleaned up the commit msg, here we go @RainbowMango

@RainbowMango RainbowMango added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Sep 11, 2024
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 11, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 11, 2024
@karmada-bot karmada-bot merged commit 60a4bcb into karmada-io:main Sep 11, 2024
6 checks passed
chouchongYHMing pushed a commit to chouchongYHMing/dashboard that referenced this pull request Sep 25, 2024
* ci: add all target in Makefile

Signed-off-by: warjiang <1096409085@qq.com>

* ci: add ci-workflow actions

Co-authored-by: Hongcai Ren <renhongcai@huawei.com>
Signed-off-by: warjiang <1096409085@qq.com>

---------

Signed-off-by: warjiang <1096409085@qq.com>
Co-authored-by: Hongcai Ren <renhongcai@huawei.com>
@warjiang warjiang deleted the ci/invoke-build-when-pr branch October 23, 2024 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setup CI workflow for PR
3 participants