Add: add i18n and translator features #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karmada-bot
added
the
kind/feature
karmada-bot
added
the
size/XXL
|
/assign |
chouchongYHMing
force-pushed
the
i18n-dev
branch
7 times, most recently
from
5ec54e3
to
3191e74
Compare
Update: add init subcommand and fix bug for jsx Signed-off-by: chouchongYHMing <yuhaoming_ai@njfu.edu.cn>
Signed-off-by: chouchongYHMing <yuhaoming_ai@njfu.edu.cn>
Signed-off-by: chouchongYHMing <yuhaoming_ai@njfu.edu.cn>
Signed-off-by: chouchongYHMing <yuhaoming_ai@njfu.edu.cn>
chouchongYHMing
force-pushed
the
i18n-dev
branch
from
1ac0d7b
to
a224c73
Compare
warjiang
reviewed
Sep 27, 2024
| case "openal": return new OpenAITranslator(key, model); | ||
|
|
||
| default: | ||
| debug('type of translate is not right'); |
There was a problem hiding this comment.
Here, we need to throw the error to make the end-user know that the type for translate config is invalid
3 tasks
|
After multiple rounds of retry, including proposal and implementation:
@chouchongYHMing finally made implemented an available version of i18n-tool 🎉 |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: warjiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
karmada-bot
added
the
approved
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
It's the out-of-the-box i18n tool, which can i18n transforms codes under development. It also offers translation feature, adapting multiple ways of translating.
Which issue(s) this PR fixes:
Fixes #95
Special notes for your reviewer:
Does this PR introduce a user-facing change?: