Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some notice for deploy #145

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JamesBonddu
Copy link

What type of PR is this?
/kind documentation

What this PR does / why we need it:

Add some notice for deploy

Which issue(s) this PR fixes:
Fixes #144

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@karmada-bot karmada-bot added the kind/documentation Categorizes issue or PR as related to documentation. label Oct 28, 2024
@karmada-bot karmada-bot requested review from jhnine and samzong October 28, 2024 13:10
@karmada-bot
Copy link
Collaborator

Welcome @JamesBonddu! It looks like this is your first PR to karmada-io/dashboard 🎉

@karmada-bot karmada-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 28, 2024
Signed-off-by: jsdu <30621150@qq.com>
@warjiang
Copy link
Contributor

/assign

Copy link
Member

@samzong samzong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great!

/approve

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: samzong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dashboard login failed
4 participants