Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sentry for monitor #147

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

warjiang
Copy link
Contributor

What type of PR is this?
/kind feature

What this PR does / why we need it:
Karmada-dashboard will be used in our end-users clusters, sometimes end-users will meet problems like crash of web-ui、system errors, for a better experience of detect bug and help end-users to solve problems quickly, we need to introduce monitor system help us capture exception stacktrace.

Which issue(s) this PR fixes:
Fixes #122

Special notes for your reviewer:

  • we need to set SENTRY_AUTH_TOKEN but lack of permission

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: warjiang <1096409085@qq.com>
Signed-off-by: warjiang <1096409085@qq.com>
@karmada-bot karmada-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 13, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from warjiang. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 13, 2024
@RainbowMango
Copy link
Member

we need to set SENTRY_AUTH_TOKEN but lack of permission

I think we can talk about it at today's meeting.

@warjiang
Copy link
Contributor Author

we need to set SENTRY_AUTH_TOKEN but lack of permission

I think we can talk about it at today's meeting.

ok~

@RainbowMango
Copy link
Member

Hi, I added the secret with the name SENTRY_AUTH_TOKEN.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce sentry
3 participants