Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does karmada can prevent removal of these managed resources #4709

Closed
CharlesQQ opened this issue Mar 13, 2024 · 6 comments
Closed

Does karmada can prevent removal of these managed resources #4709

CharlesQQ opened this issue Mar 13, 2024 · 6 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@CharlesQQ
Copy link
Contributor

CharlesQQ commented Mar 13, 2024

What would you like to be added:
Under normal circumstances, delete resource in karmada control plane, resource in mamber cluster will be deleted;
Is there any way to prevent removal of these managed resources?

Why is this needed:
Like kubefed Annotation kubefed.io/orphan: true; this feature is useful to rollback when resource migrate to karmada;
refer to (https://github.com/kubernetes-retired/kubefed/blob/master/docs/userguide.md)

@CharlesQQ CharlesQQ added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 13, 2024
@RainbowMango
Copy link
Member

That sounds like a reasonable feature. I'd like to know when and how this feature would be used.

The Kubefed annotation kubefed.io/orphan: true is added to the federated resources, corresponding to Karmada PropagationPolicy. I tend to extend the API instead of introducing an annotation.

@XiShanYongYe-Chang
Copy link
Member

I propose a simple idea. Add a new API, call it RemovePolicy, and define the target resource and the corresponding deletion policy in its resources, such as whether to keep the resources in the member cluster, or delete the resources in the member cluster synchronously, how much the deletion delay is, etc.

The idea is very rough, throw bricks lead jade.

@CharlesQQ
Copy link
Contributor Author

CharlesQQ commented Mar 25, 2024

That sounds like a reasonable feature. I'd like to know when and how this feature would be used.

Used to migrate some services from karmda. If the services migrated to karmada do not meet expectations, provide a rollback capability.

@CharlesQQ
Copy link
Contributor Author

I propose a simple idea. Add a new API, call it RemovePolicy, and define the target resource and the corresponding deletion policy in its resources, such as whether to keep the resources in the member cluster, or delete the resources in the member cluster synchronously, how much the deletion delay is, etc.

I agreed @RainbowMango idea, Add a new API might be too complicated

@XiShanYongYe-Chang
Copy link
Member

Hi everyone, let's use umbrella issue #5577 to track this requirement.
/close

@karmada-bot
Copy link
Collaborator

@XiShanYongYe-Chang: Closing this issue.

In response to this:

Hi everyone, let's use umbrella issue #5577 to track this requirement.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants