-
Notifications
You must be signed in to change notification settings - Fork 885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Umbrella] Enhancement of Karmada maturity based on Clomonitor check sets #5048
Comments
/help |
@zhzhuang-zju: Please ensure the request meets the requirements listed here. If this request no longer meets these requirements, the label can be removed In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
cc @B1F030 |
I'm glad to help! Can I take the |
done~ |
Maybe we can have the badge of CLomonitor. See example at https://github.com/kubeflow/kubeflow/blob/master/README.md. |
@RainbowMango I have added the CLOMonitor badge in my PR. |
Hey does this issue require any more help?If so, I would like to work on it |
Sure, go ahead. Please pick what interests you and do it~ |
@RainbowMango @zhzhuang-zju I have added top-level permission for ci-image-scanning workflow. Please review it. |
@RainbowMango @zhzhuang-zju I have added top-level permission for ci.yml and cli.yml workflow. Please review it. |
@aditya7302 @Akash-Singh04 Thanks for your efforts on task Token permissions. Defining the minimal permission set for workflow is actually difficult, do you have any experiences to share? Besides, how can we effectively go about verifying the results(all I can think of at the moment is local verification)? Other than that, have you encountered any other difficulties? Looking forward to your feedback! |
I found the recommended steps and an online tool to complete the task Token permissions!
Following this criterion, the recommended steps are:
So, we had a problem with the previous implementation and needed to be revised. To help determine the permissions needed for our workflows, we can use StepSecurity's online tool by ticking the "Restrict permissions for GITHUB_TOKEN". |
@zhzhuang-zju As I am new to learning workflows, I primarily use local verification to test them. This method helps me ensure that the workflows function correctly within a controlled environment. However, I think that defining the minimal permission set for large workflows can be quite challenging. |
I can't agree more~ Local verification is actually the safest way. Now with the tool Scan, this process is even easier. However, in some cases, the tool's database does not have permissions information of a certain action, we can only verify them locally or refer to other user-defined permissions. |
All tasks are done! Thank you all for your hard work! @B1F030 @zhzhuang-zju @aditya7302 @SkySingh04 For now, we reached a 99 score, and the last check( /close |
@RainbowMango: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What would you like to be added:
CLOMonitor is a tool that periodically checks open source projects repositories to verify they meet certain project health best practices, and will provide a score card for each project based on the check results. Here is the score card for karmada: https://clomonitor.io/projects/cncf/karmada. As you can see, there's still some work to be done.
Here list the check set that karmada did not pass.
license scanning (@B1F030 [License]Add foaas badge in README.md #5050)
Karamda completes the license scanning software scans in fossa workflow, so we only need add the
FOSSA
link in theREADME
file. Regexps used:"(https://app.fossa.(?:io|com)/projects/[^"'\)]+)"
Artifact Hub badge (@B1F030 Add Artifact HUB badge #5051)
OpenSSF Scorecard badge (@B1F030 Modify OpenSSF Scorecard badge #5055)
We have added the
OpenSSF
Scorecard badge in theREADME
file in Add OSSF scorecard badges #5022, but the urlhttps://api.scorecard.dev/projects/github.com/karmada-io/karmada/badge
does not match the specified regexps"(https://api.securityscorecards.dev/projects/github.com/[^/]+/[^/]+)/badge"
and needs to be modified.Dependencies policy (@zhzhuang-zju)
Software bill of materials (SBOM)(@zhzhuang-zju add sbom to release assests #5110)
Security insights (@zhzhuang-zju, add security-insights.yml #5140)
Signed releases
Karmada images have been signed with
cosign
sincerelease1.7
, but we need add the SLSA provenance file in the assets for release (*.intoto.jsonl) (@zhzhuang-zju chore: add slsa provenance to release assets #5178)Token permissions
define topLevel permission for each workflow
Roadmap (@zhzhuang-zju add roadmap to README community#78)
Summary Table (@RainbowMango Update summary of Karmada project cncf/landscape#3976)
Reference:
Why is this needed:
Improving scores is not the ultimate goal, I hope to use this issue to make Karmada healthier and more mature
The text was updated successfully, but these errors were encountered: