Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: let kube version of artifaces/deploy/karmada-apiserver versionsupport configuration. #4899

Merged
merged 1 commit into from
Jun 19, 2024
Merged

chore: let kube version of artifaces/deploy/karmada-apiserver versionsupport configuration. #4899

merged 1 commit into from
Jun 19, 2024

Conversation

liangyuanpeng
Copy link
Contributor

@liangyuanpeng liangyuanpeng commented May 4, 2024 •
edited
Loading

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

The workflow of APIServer compatibility is failing when it's running with master, see

The reason is master is running with karmada-apiserver v1.27.11, and the workflow of APIServer compatibility is change the version of karmada-apiserver by patching karmada-apiserver, and actually it's happening the downgrade/upgrade of karmada-apiserver, it's always failing if karmada-apiserver have add some new API. For now, it's flowcontrol.apiserver.k8s.io/v1beta3,
available with v1.26, so it will always failed if karmada-apiserver downgrade to lessthan v1.26

So this PR is working for useing environment to config the karmada-apiserver version, Avoid karmada-apiserver downgrade/upgrade happening.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

This PR CI is failing with the confict artifact name, will resolve by #4897

Does this PR introduce a user-facing change?:

@karmada-bot karmada-bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label May 4, 2024
@karmada-bot karmada-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 4, 2024
@codecov-commenter
Copy link

codecov-commenter commented May 4, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.14%. Comparing base (a8697ec) to head (9a32daa).
Report is 2 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4899      +/-   ##
==========================================
+ Coverage   53.12%   53.14%   +0.01%     
==========================================
  Files         251      251              
  Lines       20415    20415              
==========================================
+ Hits        10845    10849       +4     
+ Misses       8856     8853       -3     
+ Partials      714      713       -1
Flag Coverage Δ
unittests 53.14% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@karmada-bot karmada-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/contains-merge-commits Indicates a PR which contains merge commits. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 4, 2024
@karmada-bot karmada-bot removed the do-not-merge/contains-merge-commits Indicates a PR which contains merge commits. label May 7, 2024
@RainbowMango
Copy link
Member

cc @zhzhuang-zju

zhzhuang-zju
zhzhuang-zju reviewed May 8, 2024
View reviewed changes
Copy link
Contributor

@zhzhuang-zju zhzhuang-zju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your important commit! Review is ongoing, and my viewpoint just for reference only.

artifacts/deploy/karmada-apiserver.yaml Outdated Show resolved Hide resolved
artifacts/deploy/kube-controller-manager.yaml Outdated Show resolved Hide resolved
hack/deploy-karmada.sh Outdated Show resolved Hide resolved
@zhzhuang-zju
Copy link
Contributor

@liangyuanpeng By looking at the logs uploaded by CI, I found that the versions of karmada-apiserver are both v1.25.4 and have not changed based on the configured environment variables. Can you help confirm this?

@karmada-bot karmada-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 8, 2024
@liangyuanpeng
Copy link
Contributor Author

we need to cherry pick this change to branch of release, and then it can be working for release branch, i update the trigger branch to master for verify.

@zhzhuang-zju
Copy link
Contributor

we need to cherry pick this change to branch of release, a

Yes, changes to files karmada-apiserver.yaml, kube-controller-manager.yamland deploy-karmada.sh should be synchronized to previous release versions.

@liangyuanpeng It would be nice to have an issue to break down and track this task, which would also make the whole work clearer

@liangyuanpeng liangyuanpeng mentioned this pull request May 11, 2024
Closed
3 tasks
@liangyuanpeng
Copy link
Contributor Author

tracking at #4929

@liangyuanpeng liangyuanpeng force-pushed the artifact_kubeversion_param branch 3 times, most recently from 45e349a to 771e331 Compare June 18, 2024 09:03
@karmada-bot karmada-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 18, 2024
@liangyuanpeng
chore: let kube version of artifaces/deploy/karmada-apiserver version…
8e43753 
… support configuration.

Signed-off-by: Lan Liang <gcslyp@gmail.com>
@liangyuanpeng
Copy link
Contributor Author

Delete the changes of .github/workflows/ci-schedule-compatibility.yaml for clean cherrypick and leave it to the next PR.

@zhzhuang-zju
Copy link
Contributor

thanks
/lgtm
cc @RainbowMango

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 18, 2024
RainbowMango
RainbowMango reviewed Jun 19, 2024
View reviewed changes
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/assign

RainbowMango
RainbowMango approved these changes Jun 19, 2024
View reviewed changes
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
I can tell with this patch, we can specify which kube-apiserver should be used during look up, and we don't need to update images afterwards

hack/deploy-karmada.sh
@@ -200,8 +200,10 @@ fi
# deploy karmada apiserver
TEMP_PATH_APISERVER=$(mktemp -d)
trap '{ rm -rf ${TEMP_PATH_APISERVER}; }' EXIT
KARMADA_APISERVER_VERSION=${KARMADA_APISERVER_VERSION:-"v1.27.11"}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a plan to bump this to v1.28?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, i will open a PR for it ASAP.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.
I'm asking this because I guess the default version of karmadactl init/operator/chart might need to update as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope that the default version of karmada-apiserver will be consistent with the version of the dependent go module (WDYT), and will catch up to be consistent ASAP.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good idea if you mean the version of the k8s.io/xxx dependencies in go.mod file.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

k8s.io/client-go version VS kube-apiserver version

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 19, 2024
@karmada-bot karmada-bot merged commit 6fba282 into karmada-io:master Jun 19, 2024
12 checks passed
@pulsarsigs-bot pulsarsigs-bot deleted the artifact_kubeversion_param branch June 19, 2024 01:55
This was referenced Jul 4, 2024
Merged
Merged
Merged
karmada-bot added a commit that referenced this pull request Jul 4, 2024
@karmada-bot
Merge pull request #5132 from Akash-Singh04/automated-cherry-pick-of-…
4153648 
…#4899-upstream-release-1.8

Automated cherry pick of #4899: chore: let kube version of artifaces/deploy/karmada-apiserver
karmada-bot added a commit that referenced this pull request Jul 4, 2024
@karmada-bot
Merge pull request #5134 from Akash-Singh04/automated-cherry-pick-of-…
a65e791 
…#4899-upstream-release-1.10

Automated cherry pick of #4899: chore: let kube version of artifaces/deploy/karmada-apiserver
karmada-bot pushed a commit that referenced this pull request Jul 5, 2024
@SkySingh04 @liangyuanpeng
Automated cherry pick of #4899: chore: let kube version of artifaces/…
06a2b00 
…deploy/karmada-apiserver (#5133)

* chore: let kube version of artifaces/deploy/karmada-apiserver version support configuration.

Signed-off-by: Lan Liang <gcslyp@gmail.com>

* Updated version in deploy-karmadda.sh

Signed-off-by: Akash Singh <akashsingh2210670@gmail.com>

---------

Signed-off-by: Lan Liang <gcslyp@gmail.com>
Signed-off-by: Akash Singh <akashsingh2210670@gmail.com>
Co-authored-by: Lan Liang <gcslyp@gmail.com>
@RainbowMango RainbowMango added this to the v1.11 milestone Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhzhuang-zju zhzhuang-zju zhzhuang-zju left review comments

@RainbowMango RainbowMango RainbowMango approved these changes

@Garrybest Garrybest Awaiting requested review from Garrybest

Assignees

@RainbowMango RainbowMango

@zhzhuang-zju zhzhuang-zju

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.11
Development

Successfully merging this pull request may close these issues.
5 participants
@liangyuanpeng @codecov-commenter @RainbowMango @zhzhuang-zju @karmada-bot