Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define top level Permission for cli.yml workflow #5079

Merged
merged 1 commit into from
Aug 6, 2024
Merged

Define top level Permission for cli.yml workflow #5079

merged 1 commit into from
Aug 6, 2024

Conversation

SkySingh04
Copy link
Contributor

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Which issue(s) this PR fixes:
Part of #5048

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@karmada-bot karmada-bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jun 22, 2024
@karmada-bot karmada-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 22, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jun 22, 2024 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.39%. Comparing base (4124ba8) to head (c9131b0).
Report is 2 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #5079   +/-   ##
=======================================
  Coverage   28.38%   28.39%           
=======================================
  Files         632      632           
  Lines       43798    43798           
=======================================
+ Hits        12431    12435    +4     
+ Misses      30462    30460    -2     
+ Partials      905      903    -2
Flag Coverage Δ
unittests 28.39% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhzhuang-zju zhzhuang-zju mentioned this pull request Jun 25, 2024
Closed
24 tasks
zhzhuang-zju
zhzhuang-zju reviewed Jul 2, 2024
View reviewed changes
.github/workflows/cli.yaml Outdated Show resolved Hide resolved
.github/workflows/cli.yaml Outdated Show resolved Hide resolved
@SkySingh04
Copy link
Contributor Author

@zhzhuang-zju Your requested changes have been made

liangyuanpeng
liangyuanpeng reviewed Jul 4, 2024
View reviewed changes
Copy link
Contributor

@liangyuanpeng liangyuanpeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please squash the commits. and then LGTM

.github/workflows/cli.yaml Outdated Show resolved Hide resolved
@zhzhuang-zju
Copy link
Contributor

please squash the commits. and then LGTM

@Akash-Singh04 others LGTM

@SkySingh04 SkySingh04 force-pushed the toplevelpermissionsforcli.yml branch 2 times, most recently from 207e78b to 8426c23 Compare July 8, 2024 01:42
@SkySingh04
Copy link
Contributor Author

@zhzhuang-zju Done

@SkySingh04 @RainbowMango
Define top level Permission for cli.yml workflow
c9131b0 
Signed-off-by: Akash Singh <akashsingh2210670@gmail.com>
@RainbowMango
Copy link
Member

/assign @liangyuanpeng @zhzhuang-zju

@RainbowMango
Copy link
Member

Just helped rebase and resolved the left comments. Please take another look.

@liangyuanpeng
Copy link
Contributor

https://github.com/karmada-io/karmada/pull/5079/files#r1665574174 is not resolved

/appvoe
leave lgtm to @zhzhuang-zju

@liangyuanpeng
Copy link
Contributor

/approve

thanks you

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liangyuanpeng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 6, 2024
@zhzhuang-zju
Copy link
Contributor

/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 6, 2024
@karmada-bot karmada-bot merged commit 0badfc1 into karmada-io:master Aug 6, 2024
12 checks passed
@RainbowMango RainbowMango added this to the v1.11 milestone Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhzhuang-zju zhzhuang-zju zhzhuang-zju left review comments

@liangyuanpeng liangyuanpeng liangyuanpeng left review comments

@RainbowMango RainbowMango RainbowMango left review comments

@chaosi-zju chaosi-zju Awaiting requested review from chaosi-zju

Assignees

@liangyuanpeng liangyuanpeng

@zhzhuang-zju zhzhuang-zju

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.11
Development

Successfully merging this pull request may close these issues.
6 participants
@SkySingh04 @codecov-commenter @zhzhuang-zju @RainbowMango @liangyuanpeng @karmada-bot