-
Notifications
You must be signed in to change notification settings - Fork 885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add slsa provenance to release assets #5178
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5178 +/- ##
==========================================
+ Coverage 28.22% 28.36% +0.14%
==========================================
Files 632 632
Lines 43566 44070 +504
==========================================
+ Hits 12296 12500 +204
- Misses 30371 30664 +293
- Partials 899 906 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/assign
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix comments and rebase.
Signed-off-by: zhzhuang-zju <m17799853869@163.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR includes the following two things in total:
remove unused workflow step
karmada/.github/workflows/release.yml
Lines 36 to 39 in 71de3dc
add slsa provenance to release assets
This PR will generate a non-forgeable attestation to the artifacts' digests using the identity of the GitHub workflow. This can be used to create a positive attestation to a software artifact coming from karmada repository.
That means that once karmada users verify the artifacts they have downloaded they can be sure that the artifacts were created by karmada repository's workflow and haven't been tampered with.
This time a total of four slsa provenance are introduced as follows:
How to use them:
take
karmada-cli.intoto.jsonl
as example:Attestation
karmada-cli.intoto.jsonl
can be used with slsa-verifier to verify that a CLI binary was generated using Karmada workflows on GitHub and ensures it was cryptographically signed.Which issue(s) this PR fixes:
Parts of #5048
Special notes for your reviewer:
local test can refer to: https://github.com/zhzhuang-zju/karmada/actions/runs/9888187096
I will update the verification method to https://karmada.io/docs/administrator/security/verify-artifacts if this pr get merged and the next release version is released
Does this PR introduce a user-facing change?: