-
Notifications
You must be signed in to change notification settings - Fork 887
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added the scorecard github action and its badge #5303
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: harshitasao <harshitasao@gmail.com>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @harshitasao! It looks like this is your first PR to karmada-io/karmada 🎉 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5303 +/- ##
==========================================
+ Coverage 28.36% 31.15% +2.78%
==========================================
Files 632 640 +8
Lines 43774 44417 +643
==========================================
+ Hits 12416 13837 +1421
+ Misses 30458 29580 -878
- Partials 900 1000 +100
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/assign @zhzhuang-zju
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@harshitasao thanks for your work, others LGTM
Signed-off-by: harshitasao <harshitasao@gmail.com>
# Upload the results to GitHub's code scanning dashboard (optional). | ||
# Commenting out will disable upload of results to your repo's Code Scanning dashboard | ||
- name: "Upload to code-scanning" | ||
uses: github/codeql-action/upload-sarif@v3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why doesn't the action upload-sarif
use a full-length commit SHA?
What type of PR is this?
What this PR does / why we need it:
PR to add the Scorecard GitHub Action and its badge in the README file.
Which issue(s) this PR fixes:
Fixes #5229
Special notes for your reviewer:
Does this PR introduce a user-facing change?: Non