Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the scorecard github action and its badge #5303

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

harshitasao
Copy link

What type of PR is this?

What this PR does / why we need it:
PR to add the Scorecard GitHub Action and its badge in the README file.

Which issue(s) this PR fixes:
Fixes #5229

Special notes for your reviewer:

Does this PR introduce a user-facing change?: Non

NONE

Signed-off-by: harshitasao <harshitasao@gmail.com>
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kevin-wangzefeng for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot
Copy link
Collaborator

Welcome @harshitasao! It looks like this is your first PR to karmada-io/karmada 🎉

@karmada-bot karmada-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 5, 2024
@codecov-commenter
Copy link

codecov-commenter commented Aug 5, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 31.15%. Comparing base (8b4e006) to head (9af05f4).
Report is 182 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5303      +/-   ##
==========================================
+ Coverage   28.36%   31.15%   +2.78%     
==========================================
  Files         632      640       +8     
  Lines       43774    44417     +643     
==========================================
+ Hits        12416    13837    +1421     
+ Misses      30458    29580     -878     
- Partials      900     1000     +100     
Flag Coverage Δ
unittests 31.15% <ø> (+2.78%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/assign @zhzhuang-zju

Copy link
Contributor

@zhzhuang-zju zhzhuang-zju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@harshitasao thanks for your work, others LGTM

.github/workflows/scorecards.yml Outdated Show resolved Hide resolved
.github/workflows/scorecards.yml Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
.github/workflows/scorecards.yml Outdated Show resolved Hide resolved
.github/workflows/scorecards.yml Outdated Show resolved Hide resolved
.github/workflows/scorecards.yml Outdated Show resolved Hide resolved
Signed-off-by: harshitasao <harshitasao@gmail.com>
# Upload the results to GitHub's code scanning dashboard (optional).
# Commenting out will disable upload of results to your repo's Code Scanning dashboard
- name: "Upload to code-scanning"
uses: github/codeql-action/upload-sarif@v3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why doesn't the action upload-sarif use a full-length commit SHA?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable OpenSSF Scorecard to enhance security practices across the project
5 participants