Add GitHub tests for karmadactl init --config command #5306

tiansuo114 · 2024-08-06T05:58:00Z

What type of PR is this?

What this PR does / why we need it:
This PR is an additional test, based on the suggestion provided in url.
Which issue(s) this PR fixes:
Part of #5387
It adds test cases for deploying Karmada services using the karmadactl init --config command with a configuration file, similar to the existing tests for karmadactl init.

Special notes for your reviewer:
@liangyuanpeng
@RainbowMango

This PR currently contains two commits because the test files depend on the new feature for deploying with a configuration file, introduced in #5357. Once that PR is merged, this PR will be rebased, retaining only the commit for adding test cases. However, to save time, it is being submitted for review in advance.

Does this PR introduce a user-facing change?:

codecov-commenter · 2024-08-06T06:11:06Z

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.67%. Comparing base (9754a28) to head (4ceb01d).
Report is 8 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5306      +/-   ##
==========================================
+ Coverage   41.64%   41.67%   +0.02%     
==========================================
  Files         653      653              
  Lines       55484    55518      +34     
==========================================
+ Hits        23109    23135      +26     
- Misses      30876    30883       +7     
- Partials     1499     1500       +1

Flag	Coverage Δ
unittests	`41.67% <ø> (+0.02%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

tiansuo114 · 2024-08-06T08:17:18Z

May need help😭😭, in my own project's github action, these tests passed correctly, but when I commit, these tests become failed, what should I do to fix these problems
@liangyuanpeng

liangyuanpeng · 2024-08-06T09:10:21Z

/assign
/retest

liangyuanpeng · 2024-08-06T09:12:15Z

/ok-to-test

liangyuanpeng

Thanks you working for it, could you please add some e2e test here? Maybe take a look at how kubeadm does it.

pkg/karmadactl/cmdinit/kubernetes/deploy.go

pkg/karmadactl/config/init/list_option.go

tiansuo114 · 2024-08-09T04:18:58Z

Thanks you working for it, could you please add some e2e test here? Maybe take a look at how kubeadm does it.感谢您的工作，您可以在此处添加一些 e2e 测试吗？也许看看 kubeadm 是如何做到的。

I have fixed the issues you pointed out and provided new e2e test cases. Please let me know if there are any further modifications needed. :)

tiansuo114 · 2024-08-12T13:56:39Z

This PR is related to the documentation PR: #5277

liangyuanpeng · 2024-08-12T14:12:03Z

This PR is related to the documentation PR: #5277

@tiansuo114

Add to PR issue body would be great, thank you!

tiansuo114 · 2024-08-13T07:21:01Z

This PR is related to the documentation PR: #5277此 PR 与文档 PR 相关： #5277

@tiansuo114

Add to PR issue body would be great, thank you!添加到 PR 问题正文会很棒，谢谢！

Ok, I modified the pr and the other two questions about pr and added links to it

XiShanYongYe-Chang · 2024-08-15T09:03:21Z

Ask @zhzhuang-zju have a look.
/assign @zhzhuang-zju

pkg/karmadactl/karmadactl.go

pkg/karmadactl/cmdinit/kubernetes/deploy.go

liangyuanpeng · 2024-10-28T09:59:53Z

#5744 is migration to here (for Summer OSPP 2024)

tiansuo114 · 2024-10-28T11:14:12Z

Based on the OSPP project's requirements, this PR has been reopened. However, the relevant content in this PR has been changed to add automated testing for the new karmadactl init --config command as indicated in the link.

@liangyuanpeng @RainbowMango @zhzhuang-zju

tiansuo114 · 2024-10-28T11:24:24Z

/hold cancel

tiansuo114 · 2024-10-28T13:39:24Z

#5744 is migration to here (for Summer OSPP 2024)

The code in this PR has been re-pushed and tested, and after a code clean-up, I’ve removed the unnecessary metadata part in KarmadaInitConfig. We can now continue with the previous review.🎉

If need to track this issue, please refer to the relevant changes in this PR.
@RainbowMango @liangyuanpeng

liangyuanpeng

thank you!
/lgtm
/cc @zhzhuang-zju if you want to review for karmadactl

karmada-bot · 2024-10-28T16:01:02Z

@liangyuanpeng: GitHub didn't allow me to request PR reviews from the following users: want, to, review, for, if, you.

Note that only karmada-io members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

thank you!
/lgtm
/cc @zhzhuang-zju if you want to review for karmadactl

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

RainbowMango

Looks good to me, just a nit, otherwise LGTM.

RainbowMango · 2024-10-29T02:46:11Z

.github/workflows/cli.yaml

+        uses: actions/upload-artifact@v4
+        with:
+          name: karmadactl_config_test_logs_${{ matrix.k8s }}
+          path: ${{ github.workspace }}/karmadactl-test-logs/${{ matrix.k8s }}/config/


end of line.

Do you mean it’s best to add a blank line at the end of the line? If so, the code has already been updated. If I’ve misunderstood, please feel free to correct me.

Do you mean it’s best to add a blank line at the end of the line?

correct

Signed-off-by: tiansuo114 <1729765480@qq.com>

RainbowMango

/lgtm
/assign @liangyuanpeng

RainbowMango · 2024-10-29T03:27:30Z

It seems this is the last PR for the summer OSPP program. #5387.
Please let me know if I miss anything.

tiansuo114 · 2024-10-29T03:37:32Z

It seems this is the last PR for the summer OSPP program. #5387. Please let me know if I miss anything.

Yes, this PR is the last one for the OSPP tasks. Up until now, with the merge of this PR into the main branch, all planned PRs have been incorporated into Karmada.
PR Link 1: #5277
PR Link 2: #5306
PR Link 3: #5357
PR Link 4: karmada-io/website#690
PR Link 5: #5321

liangyuanpeng · 2024-10-29T06:33:00Z

It seems this is the last PR for the summer OSPP program. #5387.

Yes, it is.
/lgtm
/approve

RainbowMango

/approve

karmada-bot · 2024-10-29T06:41:25Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liangyuanpeng, RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~.github/workflows/OWNERS~~ [RainbowMango,liangyuanpeng]
~~hack/OWNERS~~ [RainbowMango,liangyuanpeng]
~~pkg/karmadactl/cmdinit/OWNERS~~ [RainbowMango]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

karmada-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 6, 2024

karmada-bot requested review from chaosi-zju and chaunceyjiang August 6, 2024 05:58

karmada-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 6, 2024

tiansuo114 changed the title ~~Add config list~~ Added karmadactl command line tool feature :karmadactl config image list Aug 6, 2024

karmada-bot assigned liangyuanpeng Aug 6, 2024

karmada-bot added the ok-to-test label Aug 6, 2024

liangyuanpeng reviewed Aug 7, 2024

View reviewed changes

pkg/karmadactl/cmdinit/kubernetes/deploy.go Outdated Show resolved Hide resolved

pkg/karmadactl/config/init/list_option.go Outdated Show resolved Hide resolved

pkg/karmadactl/config/init/list_option.go Outdated Show resolved Hide resolved

karmada-bot assigned zhzhuang-zju Aug 15, 2024

liangyuanpeng mentioned this pull request Aug 16, 2024

[Summer OSPP 2024] karmadactl init supports configuration file #5387

Closed

7 tasks

karmada-bot added the do-not-merge/contains-merge-commits Indicates a PR which contains merge commits. label Aug 30, 2024

tiansuo114 force-pushed the config branch from 81b6174 to 5c510c3 Compare August 30, 2024 02:28

karmada-bot removed the do-not-merge/contains-merge-commits Indicates a PR which contains merge commits. label Aug 30, 2024

tiansuo114 force-pushed the config branch from 5c510c3 to 8f1541d Compare August 30, 2024 02:32

zhzhuang-zju reviewed Aug 30, 2024

View reviewed changes

pkg/karmadactl/karmadactl.go Outdated Show resolved Hide resolved

pkg/karmadactl/cmdinit/kubernetes/deploy.go Outdated Show resolved Hide resolved

zhzhuang-zju reviewed Aug 30, 2024

View reviewed changes

pkg/karmadactl/cmdinit/kubernetes/deploy.go Outdated Show resolved Hide resolved

tiansuo114 force-pushed the config branch from 7e626eb to db74c26 Compare September 2, 2024 06:31

tiansuo114 closed this Oct 24, 2024

liangyuanpeng mentioned this pull request Oct 28, 2024

Feature: karmadactl init supports deployment through configuration files #5357

Merged

tiansuo114 mentioned this pull request Oct 28, 2024

Add tests for deploying Karmada services using the configuration file with the karmadactl init --config command.(closed) #5744

Closed

tiansuo114 reopened this Oct 28, 2024

tiansuo114 force-pushed the config branch from 8b5e785 to 4ceb01d Compare October 28, 2024 11:22

tiansuo114 changed the title ~~Added karmadactl command line tool feature :karmadactl config image list~~ Add tests for deploying Karmada services using the configuration file with the karmadactl init --config command. Oct 28, 2024

karmada-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 28, 2024

liangyuanpeng reviewed Oct 28, 2024

View reviewed changes

karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 28, 2024

karmada-bot requested a review from zhzhuang-zju October 28, 2024 16:01

RainbowMango changed the title ~~Add tests for deploying Karmada services using the configuration file with the karmadactl init --config command.~~ Add GitHub tests for karmadactl init --config command Oct 29, 2024

RainbowMango reviewed Oct 29, 2024

View reviewed changes

Add github ci test for karmadactl init --init-config

7426b41

Signed-off-by: tiansuo114 <1729765480@qq.com>

tiansuo114 force-pushed the config branch from 4ceb01d to 7426b41 Compare October 29, 2024 03:00

karmada-bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 29, 2024

RainbowMango reviewed Oct 29, 2024

View reviewed changes

karmada-bot assigned RainbowMango Oct 29, 2024

karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 29, 2024

RainbowMango approved these changes Oct 29, 2024

View reviewed changes

karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 29, 2024

karmada-bot merged commit 07c6cb4 into karmada-io:master Oct 29, 2024
18 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add GitHub tests for karmadactl init --config command #5306

Add GitHub tests for karmadactl init --config command #5306

tiansuo114 commented Aug 6, 2024 •

edited by RainbowMango

Loading

codecov-commenter commented Aug 6, 2024 •

edited

Loading

tiansuo114 commented Aug 6, 2024

liangyuanpeng commented Aug 6, 2024

liangyuanpeng commented Aug 6, 2024

liangyuanpeng left a comment

tiansuo114 commented Aug 9, 2024 •

edited

Loading

tiansuo114 commented Aug 12, 2024

liangyuanpeng commented Aug 12, 2024

tiansuo114 commented Aug 13, 2024

XiShanYongYe-Chang commented Aug 15, 2024

liangyuanpeng commented Oct 28, 2024

tiansuo114 commented Oct 28, 2024

tiansuo114 commented Oct 28, 2024

tiansuo114 commented Oct 28, 2024

liangyuanpeng left a comment

karmada-bot commented Oct 28, 2024

RainbowMango left a comment

RainbowMango Oct 29, 2024

tiansuo114 Oct 29, 2024

liangyuanpeng Oct 29, 2024

RainbowMango left a comment

RainbowMango commented Oct 29, 2024

tiansuo114 commented Oct 29, 2024

liangyuanpeng commented Oct 29, 2024

RainbowMango left a comment

karmada-bot commented Oct 29, 2024

Add GitHub tests for karmadactl init --config command #5306

Add GitHub tests for karmadactl init --config command #5306

Conversation

tiansuo114 commented Aug 6, 2024 • edited by RainbowMango Loading

codecov-commenter commented Aug 6, 2024 • edited Loading

Codecov Report

tiansuo114 commented Aug 6, 2024

liangyuanpeng commented Aug 6, 2024

liangyuanpeng commented Aug 6, 2024

liangyuanpeng left a comment

Choose a reason for hiding this comment

tiansuo114 commented Aug 9, 2024 • edited Loading

tiansuo114 commented Aug 12, 2024

liangyuanpeng commented Aug 12, 2024

tiansuo114 commented Aug 13, 2024

XiShanYongYe-Chang commented Aug 15, 2024

liangyuanpeng commented Oct 28, 2024

tiansuo114 commented Oct 28, 2024

tiansuo114 commented Oct 28, 2024

tiansuo114 commented Oct 28, 2024

liangyuanpeng left a comment

Choose a reason for hiding this comment

karmada-bot commented Oct 28, 2024

RainbowMango left a comment

Choose a reason for hiding this comment

RainbowMango Oct 29, 2024

Choose a reason for hiding this comment

tiansuo114 Oct 29, 2024

Choose a reason for hiding this comment

liangyuanpeng Oct 29, 2024

Choose a reason for hiding this comment

RainbowMango left a comment

Choose a reason for hiding this comment

RainbowMango commented Oct 29, 2024

tiansuo114 commented Oct 29, 2024

liangyuanpeng commented Oct 29, 2024

RainbowMango left a comment

Choose a reason for hiding this comment

karmada-bot commented Oct 29, 2024

tiansuo114 commented Aug 6, 2024 •

edited by RainbowMango

Loading

codecov-commenter commented Aug 6, 2024 •

edited

Loading

tiansuo114 commented Aug 9, 2024 •

edited

Loading