-
Notifications
You must be signed in to change notification settings - Fork 885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cleanup: change *kubeclient.Clientset to kubeclient.Interface in unregister module #5594
Conversation
Welcome @wulemao! It looks like this is your first PR to karmada-io/karmada 🎉 |
b27fb80
to
676faf2
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5594 +/- ##
=======================================
Coverage 41.58% 41.58%
=======================================
Files 655 655
Lines 55753 55753
=======================================
Hits 23186 23186
Misses 31062 31062
Partials 1505 1505
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…gister module Signed-off-by: wulemao <1194736083@qq.com>
676faf2
to
e0017b6
Compare
karmadactl unjoin
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
cleanup: change
*kubeclient.Clientset
tokubeclient.Interface
in unregister moduleWhich issue(s) this PR fixes:
Part of #5380
Special notes for your reviewer:
Does this PR introduce a user-facing change?: