-
Notifications
You must be signed in to change notification settings - Fork 887
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added tests for pkg/detector #5631
Added tests for pkg/detector #5631
Conversation
Signed-off-by: Anuj Agrawal <anujagrawal380@gmail.com>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5631 +/- ##
==========================================
+ Coverage 35.19% 35.92% +0.73%
==========================================
Files 645 645
Lines 44869 44869
==========================================
+ Hits 15791 16121 +330
+ Misses 27846 27448 -398
- Partials 1232 1300 +68
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @anujagrawal699 How about splitting this pr?
/assign |
Description:
This PR enhances the unit tests for the Resource Detector in the detector package. The improvements aim to increase code reliability, maintainability, and test coverage for the Resource Detector.
This PR introduces comprehensive unit tests for various functions in the Resource Detector, including:
Additions and Modifications:
Test Coverage:
Overall coverage of detector package: 19.58% to 50.00%
What type of PR is this?
/kind feature
Which issue(s) this PR fixes:
Fixes a part of #5470
Does this PR introduce a user-facing change?: