Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tests for pkg/detector #5631

Conversation

anujagrawal699
Copy link
Contributor

Description:
This PR enhances the unit tests for the Resource Detector in the detector package. The improvements aim to increase code reliability, maintainability, and test coverage for the Resource Detector.
This PR introduces comprehensive unit tests for various functions in the Resource Detector, including:

  • GVRDisabled and NeedLeaderElection
  • EventFilter
  • OnAdd, OnUpdate, OnDelete
  • LookForMatchedPolicy and LookForMatchedClusterPolicy
  • ApplyPolicy and ApplyClusterPolicy
  • ClaimPolicyForObject and ClaimClusterPolicyForObject
  • BuildResourceBinding and BuildClusterResourceBinding
  • isWaiting, AddWaiting and RemoveWaiting
  • Handling of PropagationPolicy and ClusterPropagationPolicy events
  • Cleanup operations for ResourceBinding and ClusterResourceBinding

Additions and Modifications:

  1. pkg/detector/detector_test.go

Test Coverage:

  1. detector_test.go: Significant increase in coverage from 1.62% to 50.80%

Overall coverage of detector package: 19.58% to 50.00%

What type of PR is this?
/kind feature

Which issue(s) this PR fixes:
Fixes a part of #5470

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Anuj Agrawal <anujagrawal380@gmail.com>
@karmada-bot karmada-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 1, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign xishanyongye-chang for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 1, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 1, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.92%. Comparing base (8cc712f) to head (2d343b6).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5631      +/-   ##
==========================================
+ Coverage   35.19%   35.92%   +0.73%     
==========================================
  Files         645      645              
  Lines       44869    44869              
==========================================
+ Hits        15791    16121     +330     
+ Misses      27846    27448     -398     
- Partials     1232     1300      +68     
Flag Coverage Δ
unittests 35.92% <ø> (+0.73%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @anujagrawal699 How about splitting this pr?

@XiShanYongYe-Chang
Copy link
Member

/assign

@anujagrawal699
Copy link
Contributor Author

Tracked by #5711 and #5746

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants