Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep preserveResourcesOnDeletion of the dependent resource consistent with that of the primary resource #5717

Conversation

XiShanYongYe-Chang
Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang commented Oct 22, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

When users enable dependency distribution for a resource template, it will inherit the PreserveResourcesOnDeletion policy from the resource they are following. As a result, we can rollback the migration of dependency distributed resources.

Which issue(s) this PR fixes:
Part of #5577

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

`karmada-controller-manager`: keep preserveResourcesOnDeletion of the dependent resource consistent with that of the primary resource

@karmada-bot karmada-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 22, 2024
@karmada-bot karmada-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 22, 2024
@XiShanYongYe-Chang
Copy link
Member Author

/cc @CharlesQQ @RainbowMango

@karmada-bot
Copy link
Collaborator

@XiShanYongYe-Chang: GitHub didn't allow me to request PR reviews from the following users: CharlesQQ.

Note that only karmada-io members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @CharlesQQ @RainbowMango

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@codecov-commenter
Copy link

codecov-commenter commented Oct 22, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.53%. Comparing base (13df63f) to head (f63c134).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5717   +/-   ##
=======================================
  Coverage   40.52%   40.53%           
=======================================
  Files         650      650           
  Lines       55184    55187    +3     
=======================================
+ Hits        22365    22369    +4     
+ Misses      31386    31385    -1     
  Partials     1433     1433           
Flag Coverage Δ
unittests 40.53% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@XiShanYongYe-Chang XiShanYongYe-Chang force-pushed the handle-preserveResource-with-dependency branch 2 times, most recently from 7e9dc2f to badf01f Compare October 23, 2024 02:14
@karmada-bot karmada-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 23, 2024
@XiShanYongYe-Chang XiShanYongYe-Chang force-pushed the handle-preserveResource-with-dependency branch from badf01f to 23d7de8 Compare October 23, 2024 02:21
Signed-off-by: changzhen <changzhen5@huawei.com>
@XiShanYongYe-Chang XiShanYongYe-Chang force-pushed the handle-preserveResource-with-dependency branch from 23d7de8 to f63c134 Compare October 23, 2024 02:25
@karmada-bot karmada-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 23, 2024
@XiShanYongYe-Chang XiShanYongYe-Chang changed the title Handle preserveResourceOnDeletion with dependencise distributor Rollback the migration of dependency distributed resources Oct 23, 2024
@chaosi-zju
Copy link
Member

chaosi-zju commented Oct 24, 2024

/lgtm

cc @RainbowMango

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 24, 2024
@XiShanYongYe-Chang XiShanYongYe-Chang changed the title Rollback the migration of dependency distributed resources Keep preserveResourcesOnDeletion of the dependent resource consistent with that of the primary resource Oct 24, 2024
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 24, 2024
@karmada-bot karmada-bot merged commit 7347f11 into karmada-io:master Oct 24, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants