-
Notifications
You must be signed in to change notification settings - Fork 885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keep preserveResourcesOnDeletion of the dependent resource consistent with that of the primary resource #5717
Keep preserveResourcesOnDeletion of the dependent resource consistent with that of the primary resource #5717
Conversation
@XiShanYongYe-Chang: GitHub didn't allow me to request PR reviews from the following users: CharlesQQ. Note that only karmada-io members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
c2d9eaf
to
4b03ff0
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5717 +/- ##
=======================================
Coverage 40.52% 40.53%
=======================================
Files 650 650
Lines 55184 55187 +3
=======================================
+ Hits 22365 22369 +4
+ Misses 31386 31385 -1
Partials 1433 1433
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
7e9dc2f
to
badf01f
Compare
badf01f
to
23d7de8
Compare
Signed-off-by: changzhen <changzhen5@huawei.com>
23d7de8
to
f63c134
Compare
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
When users enable dependency distribution for a resource template, it will inherit the
PreserveResourcesOnDeletion
policy from the resource they are following. As a result, we can rollback the migration of dependency distributed resources.Which issue(s) this PR fixes:
Part of #5577
Special notes for your reviewer:
Does this PR introduce a user-facing change?: