Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tests for pkg/util/helper/work.go #5742

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

anujagrawal699
Copy link
Contributor

@anujagrawal699 anujagrawal699 commented Oct 24, 2024

Description:
This PR adds comprehensive unit tests for untested functions of the module work from the helper utility package. It introduces new tests for previously uncovered functions and refactors existing tests to use the assert package from testify. These additions aim to increase code reliability, maintainability, and test coverage for the work helper.

Modifications:

  1. pkg/util/helper/work.go

Test Coverage:

  1. pkg/util/helper/work.go : 27.78% to 92.2%

What type of PR is this?
/kind feature

Which issue(s) this PR fixes:
Fixes a part of #5470

Does this PR introduce a user-facing change?:

NONE

@karmada-bot karmada-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 24, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign chaunceyjiang for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 24, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 24, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.49%. Comparing base (e204459) to head (da62660).
Report is 4 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5742      +/-   ##
==========================================
+ Coverage   40.85%   41.49%   +0.64%     
==========================================
  Files         651      651              
  Lines       55259    55259              
==========================================
+ Hits        22577    22932     +355     
+ Misses      31240    30846     -394     
- Partials     1442     1481      +39     
Flag Coverage Δ
unittests 41.49% <ø> (+0.64%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhzhuang-zju
Copy link
Contributor

/assign

pkg/util/helper/work_test.go Show resolved Hide resolved
pkg/util/helper/work_test.go Outdated Show resolved Hide resolved
pkg/util/helper/work_test.go Show resolved Hide resolved
Signed-off-by: Anuj Agrawal <anujagrawal380@gmail.com>

Added tests for pkg/util/helper/work.go

Signed-off-by: Anuj Agrawal <anujagrawal380@gmail.com>
@anujagrawal699 anujagrawal699 force-pushed the addedTests-pkg/util/helper/work.go branch from 5140eb1 to da62660 Compare October 25, 2024 07:54
@karmada-bot karmada-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 25, 2024
@XiShanYongYe-Chang
Copy link
Member

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants