Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added second part of unit tests for pkg/detector #5746

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

anujagrawal699
Copy link
Contributor

Description:
This PR significantly enhances the unit tests for the detector package. The improvements aim to increase code reliability, maintainability, and test coverage for various detector functions.

Modifications:

  1. pkg/detector/detector_test.go

Key Improvements:

  1. Implemented tests for ClaimPolicyForObject and ClaimClusterPolicyForObject function
  2. Added tests for BuildResourceBinding and BuildClusterResourceBinding function
  3. Implemented comprehensive tests for isWaiting, AddWaiting, and RemoveWaiting functions
  4. Added tests for OnPropagationPolicyAdd, OnPropagationPolicyUpdate, OnClusterPropagationPolicyAdd and OnClusterPropagationPolicyUpdate functions
  5. Added tests for HandlePropagationPolicyDeletion, HandleClusterPropagationPolicyDeletion, HandlePropagationPolicyCreationOrUpdate and HandleClusterPropagationPolicyCreationOrUpdate functions
  6. Created mock implementations for various interfaces to facilitate testing

Test Coverage:
pkg/detector/detector.go: 27.83% to 48.1%

What type of PR is this?
/kind feature

Which issue(s) this PR fixes:
Fixes a part of #5470

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Anuj Agrawal <anujagrawal380@gmail.com>
@karmada-bot karmada-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 26, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign garrybest for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Oct 26, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 26, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.91%. Comparing base (53c00f7) to head (3a0abd2).
Report is 14 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5746      +/-   ##
==========================================
+ Coverage   41.38%   41.91%   +0.52%     
==========================================
  Files         651      653       +2     
  Lines       55259    55484     +225     
==========================================
+ Hits        22867    23254     +387     
+ Misses      30913    30702     -211     
- Partials     1479     1528      +49     
Flag Coverage Δ
unittests 41.91% <ø> (+0.52%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@XiShanYongYe-Chang
Copy link
Member

/cc @zhzhuang-zju
/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants