Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: unify karmada labels/annotations usage in execution controller and test #5747

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

a7i
Copy link
Contributor

@a7i a7i commented Oct 26, 2024

What type of PR is this?

/kind cleanup

What this PR does / why we need it:
So we don't manage them in two different places and end up missing updating one

Which issue(s) this PR fixes:
None

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@karmada-bot karmada-bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Oct 26, 2024
@karmada-bot karmada-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 26, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 26, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.66%. Comparing base (1cd75f4) to head (1a7409d).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5747   +/-   ##
=======================================
  Coverage   41.65%   41.66%           
=======================================
  Files         653      653           
  Lines       55533    55518   -15     
=======================================
- Hits        23135    23132    -3     
+ Misses      30894    30885    -9     
+ Partials     1504     1501    -3     
Flag Coverage Δ
unittests 41.66% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

… and test

Signed-off-by: Amir Alavi <amiralavi7@gmail.com>
@chaosi-zju
Copy link
Member

pretty clean code, thanks

/lgtm

Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot~
/approve

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: XiShanYongYe-Chang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 28, 2024
@karmada-bot karmada-bot merged commit e65e993 into karmada-io:master Oct 28, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants